Formation members get their orders from the formation controller, so they shouldn't use IsWalkingAndFighting.
Details
Details
- Reviewers
- None
- Commits
- rP21655: Formation members shouldn't use IsWalkingAndFighting
- Trac Tickets
- #5108
Agree.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| binaries/data/mods/public/simulation/components/UnitAI.js | ||
|---|---|---|
| 3326 ↗ | (On Diff #6296) | I've not tested it, so can't say for sure but that looks reasonnable. |
| binaries/data/mods/public/simulation/components/UnitAI.js | ||
|---|---|---|
| 3326 ↗ | (On Diff #6296) | That's the member state for the formation controller, which it goes into after it tells members to do something. The members themselves are in the usual individual combat attacking state. |
| binaries/data/mods/public/simulation/components/UnitAI.js | ||
|---|---|---|
| 3326 ↗ | (On Diff #6296) | Eh, maybe could delete these two lines too. Is it possible for a unit to have an individual WalkAndFight or Patrol order and still be a member of some formation? Meh. |
| binaries/data/mods/public/simulation/components/UnitAI.js | ||
|---|---|---|
| 3326 ↗ | (On Diff #6296) | All formation members should have the same order (afaik), so if one has WalkAndFight all have. Also giving 1 member of a formation such an order it will disband from the formation, so I guess the answer is no. |