Page MenuHomeWildfire Games

Ptol catapults should unpack to ptol catapults, not mace catapults
ClosedPublic

Authored by causative on Apr 28 2018, 10:34 AM.

Details

Summary

Split from D1473 since that has become controversial with the addition of SelectionGroupNames for siege engines which is not really related. Since most of the discussion in D1473 was about SelectionGroupNames, I'll keep D1473 for the SelectionGroupName related changes and make this new one for the original uncontroversial fix.

Packed ptolemy catapults previously unpacked to macedonian catapults. Also, unpacked ptolemy catapults packed to macedonian catapults. This created a minor gameplay problem where double clicking your packed catapults as ptolemy would not select all of them, because the catapults that had already been unpacked and packed had a different template from those that were never unpacked.

Test Plan

Produce a catapult as ptolemy, unpack it, verify that it still functions as it should, and pack it again. Using the developer overlay, view the template of the catapult to see that it is a ptolemy catapult and not a macedonian one.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Vulcan added a subscriber: Vulcan.Apr 28 2018, 10:53 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/444/display/redirect

mimo accepted this revision.Apr 28 2018, 11:25 AM
mimo added a subscriber: mimo.

Thanks for spliting the uncontroversial part.

This revision is now accepted and ready to land.Apr 28 2018, 11:25 AM
This revision was automatically updated to reflect the committed changes.
elexis added a subscriber: elexis.Apr 28 2018, 11:48 AM

For future reference, this diff is the same as D1032 which was reverted by rP20483.