See #5129
Details
- Reviewers
Silier - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23592: Add a C++ interface for CCmpAttack.
- Trac Tickets
- #5129
Note the code now works as expected.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/simulation2/components/ICmpAttack.h | 23| class·ICmpAttack·:·public·IComponent | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classICmpAttack:' is invalid C code. Use --std or --language to configure the language. source/tools/atlas/GameInterface/ActorViewer.cpp | 211| » /** | | [MAJOR] CPPCheckBear (syntaxError): | | Unmatched '}'. Configuration: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... binaries/data/mods/public/simulation/components/Attack.js | 430| » return·{ | | [NORMAL] ESLintBear (consistent-return): | | Function expected no return value. Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1882/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/simulation2/components/ICmpAttack.h | 23| class·ICmpAttack·:·public·IComponent | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classICmpAttack:' is invalid C code. Use --std or --language to configure the language. source/tools/atlas/GameInterface/ActorViewer.cpp | 211| » /** | | [MAJOR] CPPCheckBear (syntaxError): | | Unmatched '}'. Configuration: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... binaries/data/mods/public/simulation/components/Attack.js | 430| » return·{ | | [NORMAL] ESLintBear (consistent-return): | | Function expected no return value. Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1883/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/simulation2/components/ICmpAttack.h | 23| class·ICmpAttack·:·public·IComponent | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classICmpAttack:' is invalid C code. Use --std or --language to configure the language. source/tools/atlas/GameInterface/ActorViewer.cpp | 211| » /** | | [MAJOR] CPPCheckBear (syntaxError): | | Unmatched '}'. Configuration: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2000/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2001/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/587/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1474/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/simulation2/components/ICmpAttack.h | 23| class·ICmpAttack·:·public·IComponent | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classICmpAttack:' is invalid C code. Use --std or --language to configure the language. source/tools/atlas/GameInterface/ActorViewer.cpp | 211| » /** | | [MAJOR] CPPCheckBear (syntaxError): | | Unmatched '}'. Configuration: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2002/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/593/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1480/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2007/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/594/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1481/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2008/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/tools/atlas/GameInterface/ActorViewer.h | 1| /*·Copyright·(C)·2019·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2020" year instead of "2019" source/tools/atlas/GameInterface/ActorViewer.h | 29| class·ActorViewer | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classActorViewer{' is invalid C code. Use --std or --language to configure the language. source/simulation2/components/ICmpAttack.h | 23| class·ICmpAttack·:·public·IComponent | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classICmpAttack:' is invalid C code. Use --std or --language to configure the language. source/tools/atlas/GameInterface/ActorViewer.cpp | 211| » /** | | [MAJOR] CPPCheckBear (syntaxError): | | Unmatched '}'. Configuration: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2009/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/tools/atlas/GameInterface/ActorViewer.h | 1| /*·Copyright·(C)·2019·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2020" year instead of "2019" source/tools/atlas/GameInterface/ActorViewer.h | 29| class·ActorViewer | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classActorViewer{' is invalid C code. Use --std or --language to configure the language. source/simulation2/components/ICmpAttack.h | 23| class·ICmpAttack·:·public·IComponent | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classICmpAttack:' is invalid C code. Use --std or --language to configure the language. source/tools/atlas/GameInterface/ActorViewer.cpp | 211| » /** | | [MAJOR] CPPCheckBear (syntaxError): | | Unmatched '}'. Configuration: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2010/display/redirect
Remove useless local variable
Only set speed if using moving animations
Bump copyright
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/598/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1485/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2012/display/redirect
source/tools/atlas/GameInterface/ActorViewer.cpp | ||
---|---|---|
419 ↗ | (On Diff #11691) |
|
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/tools/atlas/GameInterface/ActorViewer.h | 29| class·ActorViewer | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classActorViewer{' is invalid C code. Use --std or --language to configure the language. source/simulation2/components/ICmpAttack.h | 23| class·ICmpAttack·:·public·IComponent | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classICmpAttack:' is invalid C code. Use --std or --language to configure the language. source/tools/atlas/GameInterface/ActorViewer.cpp | 211| » /** | | [MAJOR] CPPCheckBear (syntaxError): | | Unmatched '}'. Configuration: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2013/display/redirect
source/tools/atlas/GameInterface/ActorViewer.cpp | ||
---|---|---|
423 ↗ | (On Diff #11524) | Yep. |
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/tools/atlas/GameInterface/ActorViewer.h | 29| class·ActorViewer | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classActorViewer{' is invalid C code. Use --std or --language to configure the language. source/simulation2/components/ICmpAttack.h | 23| class·ICmpAttack·:·public·IComponent | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classICmpAttack:' is invalid C code. Use --std or --language to configure the language. source/tools/atlas/GameInterface/ActorViewer.cpp | 211| » /** | | [MAJOR] CPPCheckBear (syntaxError): | | Unmatched '}'. Configuration: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2014/display/redirect
source/simulation2/components/ICmpAttack.cpp | ||
---|---|---|
34 ↗ | (On Diff #11692) | (const ref? might need some overload) |
source/tools/atlas/GameInterface/ActorViewer.cpp | ||
395 ↗ | (On Diff #11692) | (excess space) |
412 ↗ | (On Diff #11692) | (good!) |
415 ↗ | (On Diff #11692) | (would be good to remove the hardcoding without substring construction, but can be done elsewhere) |
487 ↗ | (On Diff #11692) | const ref? (perhaps one can avoid std::string construction and pass the char*, but probably not so important here) |
423 ↗ | (On Diff #11524) | What does bugged mean? Is it an unused variable and the variable is still unused after this patch? |
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/tools/atlas/GameInterface/ActorViewer.h | 29| class·ActorViewer | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classActorViewer{' is invalid C code. Use --std or --language to configure the language. source/simulation2/components/ICmpAttack.h | 23| class·ICmpAttack·:·public·IComponent | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classICmpAttack:' is invalid C code. Use --std or --language to configure the language. source/tools/atlas/GameInterface/ActorViewer.cpp | 211| » /** | | [MAJOR] CPPCheckBear (syntaxError): | | Unmatched '}'. Configuration: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2017/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2019/display/redirect