Page MenuHomeWildfire Games

Increase maximum number of units that can be selected at once
AcceptedPublic

Authored by Serihilda on Jun 8 2023, 12:15 PM.

Details

Reviewers
wowgetoffyourcellphone
Trac Tickets
#6823
Summary

Please see https://trac.wildfiregames.com/ticket/6823

Players need to be able to select more than 200 units at once, but not too many, otherwise lag. So 300 is a sweet spot.

Type: GUI. Can be done with a simple compatible mod but why not just commit it as a default feature ?

Test Plan

Already tested. Still quite smooth for 300 units, serious lag starts at 400.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Serihilda requested review of this revision.Jun 8 2023, 12:15 PM
Serihilda created this revision.
Stan added a subscriber: Stan.EditedJun 8 2023, 1:05 PM

Maybe it should be a game option instead? 300 is likely to be more problematic than 200 on a lot of hardware

sera added a subscriber: sera.Jun 8 2023, 1:11 PM

Last updated with rP9745, given that the default pop is 300 this change seems reasonable.

As for performance, using 600 (double the suggested value) I only see an acceptable impact on rendering speed due to those extra selection circles, health bars, chevrons, etc., selection itself is still feels instantaneous.

wraitii added a subscriber: wraitii.Jun 8 2023, 2:37 PM

Thanks Freagarach, was wondering why it wasn't an option already :P

Ideally I think this would need a little more testing, but I believe we still have some rather slow code during GUI updates. I'm not sure 300 is much worse than 200 though, and the 'max pop' argument makes sense to me.

Right, the selection pop matching up with the default max pop has a kind of logic to it.

This revision is now accepted and ready to land.Mar 3 2024, 6:20 PM