In D2642#119901, @vladislavbelov wrote:

Shouldn't the CAS license be mentioned in LICENSE.txt?

Add license, change header year.

Add context.

The current version is not profiled yet, so I do not know, which of these functions will improve performance.
"-" and "+" seems to have grate impact to the game, when many units are in the field of view. Until yet I didn't get it profiled, when many units are used.

Updating the licence and the link, as AMD had updated it. Changing the game options name to the AMD recommented one.

I have tested with different setups.

Modified it, so it could be used on all maps.

Revert to previous version and edit some comments.

First time using Arcanist. Something went wrong, files are missing. How can I turn back to previous version?

1. Updating D2642: Contrast-Adaptiv-Sharpening pass #
2. Enter a brief description of the changes included in this update.
3. The first line is used as subject, next lines as comment. #
4. If you intended to create a new revision, use:
5. $ arc diff --create

Waiting until D2712 is committed. A little modification of the code of this patch has to be done.

Patch is working as expected. All tests passed as it should. Code looks correct.
Accepted. Thank you Vladislav

The patch is waiting for reviewing, what update do you want to have? The patch is mostly working. As it have the same problem as the FXAA patch, that it doesn’t work on all maps, and I don't know how to solve it, I will wait and see, how Vladislav is solving this problem.
If you want to test it, you could choose e.g. the new shirmish maps Obedska Bog or Sahyadri Buttes.

Works on Intel UHD 620 with Windows.

Patch is working on my AMD Radeon RX 570 Manjaro Linux and Windows system.

In rP23484#41603, @Stan wrote:

In rP23484#41600, @OptimusShepard wrote:

FXAA doesn't work on my linux system. On dual boot Windows it's working.
Manjaro 64Bit, Radeon RX 570

interestinglog.html6 KBDownload

Same map? It doesn't work on all maps if postprocessing is disabled on the map settings...

FXAA doesn't work on my linux system. On dual boot Windows it's working.
Manjaro 64Bit, Radeon RX 570

Thx

Change the representation of floats in cas.fs.

Add an editing info to the cas.fs header.

Add slider for sharpness factor.

In D2642#110937, @gameboy wrote:

I use Intel CPU, and the graphics card USES NVIDIA GTX850M. The operating system is Windows10 64bit. Do you support Intel CPU and NVIDIA series of graphics CARDS in this patch

Replace rcp(x) to 1/x.
rcp seems to be a performance optimized function for AMD GPUs. As strange, rsqrt is also a special function, which doesn't work with my GPU. I had it replaced bevor my first upload.
@vladislavbelov do you know more about such things? Is it possible to implement a parallel path for AMD hardware?

In D2642#110914, @Stan wrote:

AFAIK @gameboy uses Windows.

In D2642#110901, @gameboy wrote:

@OptimusShepard I tested your patch and when I select CAS in the options, the error appears：

ERROR: Failed to compile shader 'shaders/glsl/cas.fs': 0(64) : warning C1503: undefined variable "rcp" 0(70) : warning C1503: undefined variable "rcp" 0(73) : warning C1503: undefined variable "rcp" 0(64) : error C1008: undefined variable "rcp" 0(70) : error C1008: undefined variable "rcp" 0(73) : error C1008: undefined variable "rcp"

I will add a slider for selecting the sharpness factor.

Do I have to add something to the LICENSE.txt?
I ported the reshade port of AMDs CAS, so is there anything else to consider?

The ultra widescreen support should be taken into account in a future revision of the gui.

The game is still running correctly. I recognize an performance improvement up to 10%.

The game does run without problems. I can't recognize any difference between with/without "Prefer GLSL".

In D2537#106648, @OptimusShepard wrote:

As I know AMD has made his new Radeon Image Sharpening filter free open source, I would recommend to have a look on it.

I would suggest to split the anti-aliasing and the sharpening filter in two seperat options in the settings. Also I like the idea to have a slider that everyone could take is favor settings. As I know AMD has made his new Radeon Image Sharpening filter free open source, I would recommend to have a look on it. The quality is very impressive.

I've made a mistake by testing procedure. So I didn't seen that the OOM only occurs when I used a version which I compiled myself. So the bug is related to my Visual Studio settings or something like that. Sorry for that.

Added comment with link.

I tested the game with, and without the patch for several times. With the patch the game crashes with an OOM after 30-45min. The OOM report isn't every time the same. Without the patch the game crashes only at the start. I have tested it with following settings. Mapsize big, very huge start ressources, 4 ai vs 4 ai, anatolien plateau, speed 20x.
In my opinion someone should take the current documentation of AMD and make a clean implementation.

Can you test if the OOM is reproductible though?

I currently have no time to write the patch, sorry. If someone else writes this patch I would test it.
Here are the required information which Imarok got from the AMD forum.

In D2353#98805, @Stan wrote:

@OptimusShepard will you update the patch ? :)

In D2353#98463, @Imarok wrote:

In D2353#98462, @elexis wrote:

In D2353#98374, @Imarok wrote:

I think we now had multiple Zen 2 users complaining about crashes.

Got a link?

Just see the ticket and the link in the post above.

Here is another link. https://wildfiregames.com/forum/index.php?/topic/15796-known-problems-please-read-before-posting/&do=findComment&comment=384917
So we allready have Ryzen 3600, 3600X, 3700X and 3800X. So we only miss a crash report of an 3900X user to complete the Ryzen Zen2 series.

In D2353#98365, @elexis wrote:

This #4360?

Before the patch the balkon position was wrong.

hotkey "alt" for change to freehand formation is not implemented yet. It's currently activated every time.

Good Point. I have quickly tested it for every map size. Seems to be that docks could be built on the whole shoreline.

I know what your mean, but I think this isn't necessary. "5" looks like a good compromise on all maps I think. Interestingly, this problem doesn't occur on gigantic map size.
Maybe someone will later rework the complete map, there are a little bit too much animals, and there are also some unreachable trees. Until then this patch should work fine I think.

In D1590#63859, @elexis wrote:

In D1590#63856, @OptimusShepard wrote:

Don't you gather hardware informations? I didn't read something like that.

That's the UserReporter seen in the main menu.
That is not sent to the Multiplayer Lobby service and it's not related to the lobby either.
It is sent in the main menu, has custom terms (we didn't check that for GDPR complience yet), sent for singleplayer matches too
and the sent data does as far as I know not contain the lobby username nor an IP address but a unique userreporter ID saved in the users config file.

So you raise an important point, users should find out how the personal data of other service affects their rights.
The lobby terms should probably link to a document with references to the terms of the different places.

Don't you gather hardware informations? I didn't read something like that.

Does this patch works only for your own units, or also for the enemy units? Because I think you want to be able to block them, e.g. when you try to defend something.

I think most useful would be if the units attack the siege units by default instead of try to capturing them.

Maybe the min range should be smaler than the max range of skirmisher. Otherwise they could attack them as long as they want without getting damaged. And skirmisher will need much time..

The units also should maybe prefer to attack than to capture the siege units.

I don't think that they are such more op dann other units in a mass. If you have many catapults, rams, siege towers or horsemen archer they are also hard to stop. Catapults, rams and 2-3 sword horsemen bring them easy down. You only should give attention how do you attack them. There is freehand position a good possibilty (attack in a big line) that every bolt can only hit one horsemen.

I think this patch have to be in alpha 23. It doesn't solve the problem of #4883, but it saves from his consequences.

Thx, patch is working. Maybe the first error had caused the other.

In D1450#59282, @aeonios wrote:

In D1450#59278, @OptimusShepard wrote:

Doesn't work on Win 10.

ERROR: Failed to link program 'shaders/glsl/terrain_common.vs'+'shaders/glsl/terrain_common.fs': Fragment info ------------- 0(93) : error C7623: implicit narrowing of type from "vec4" to "float"

ERROR: Failed to link program 'shaders/glsl/model_common.vs'+'shaders/glsl/model_common.fs': Fragment info ------------- 0(94) : error C7623: implicit narrowing of type from "vec4" to "float"

What gfx card are you using?

Doesn't work on Win 10.

Is it correct that by chosing high settings without saving the error occurs? Shouldn't the settings be changed after saving? But I think this is another bug.

Patch is working, thx. Maybe you want to display some information to the user that you have change her/his settings?

add transparency to picture

So we change it if we have a usecase?

In D1368#56469, @elexis wrote:

About the imge format itself, do what the other files do, i.e. 512*512 with the actual contents 512*384. Not sure if the rest has to be transparent or if black works too.

Can someone else please add the transparency, black didn't work?

I like the 0AD unit formation, really shows what it can do. But perhaps it should take place on a more beautiful map than anatolian plateau.

The mouse has an mspaint feeling to it like Stan said, perhaps we can omit it altogether and just describe it in the tooltip.

nearly ^^ I did it with Visio :D

(Also eventually it should become a hotkey, not hardcoded to the rightclick.)

I think right mouse is more intuitiv and practicaly than a hotkey?

update the text

without blue shadows

take what you prefer

maybe more 0AD style

Do you prefer some other colors, or completely with out?

Does someone know how to adjust the picture correctly?

replace vector

correcting language of some variable

In D1352#55684, @elexis wrote:

Perhaps it's more relevant to test the actual distance between the positions. (One can move the mouse fast, then there's a lot of space in between, right?)
But presumably not worth the complexity.

improve performance