Page MenuHomeWildfire Games

Update the fast-actions cheat and AI bonuses to use the modifiers manager
ClosedPublic

Authored by wraitii on Nov 4 2017, 8:07 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22964: Update the fast-actions cheat and AI bonuses to use the modifiers manager
Summary

Using D274 and the modifications manager, we can implement the fast-actions cheat without custom code.

Test Plan

Test it out.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Nov 4 2017, 8:07 PM
Vulcan added a subscriber: Vulcan.Nov 4 2017, 8:10 PM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Vulcan added a comment.Nov 4 2017, 8:11 PM
Executing section Default...
Executing section Source...
Executing section JS...

binaries/data/mods/public/simulation/components/Upgrade.js
| 129| »   »   let·templateName·=·cmpIdentity·?·choice.Entity.replace(/\{civ\}/g,·cmpIdentity.GetCiv())·:·choice.Entity
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/helpers/Cheat.js
|  76| »   »   »   cmpModificationsManager.RemoveGlobalModifications("cheat/fastactions")
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/helpers/Cheat.js
| 116| »   »   var·cmpTechnologyManager·=·Engine.QueryInterface(playerEnt,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.

binaries/data/mods/public/simulation/helpers/Cheat.js
| 123| »   »   »   var·cmpProductionQueue·=·Engine.QueryInterface(input.selected[0],·IID_ProductionQueue);
|    | [NORMAL] JSHintBear:
|    | 'cmpProductionQueue' is already defined.

binaries/data/mods/public/simulation/components/Player.js
| 330| »   for·(var·type·in·amounts)
|    | [NORMAL] JSHintBear:
|    | 'type' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 189| »   for·(var·i·in·techList)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 191| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 203| »   for·(var·i·=·0;·i·<·techList.length;·i++)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 205| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 212| »   »   var·template·=·cmpTechnologyManager.GetTechnologyTemplate(tech);
|    | [NORMAL] JSHintBear:
|    | 'template' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 241| »   »   »   ||·cmpTechnologyManager.IsTechnologyResearched(template.bottom)·||·cmpTechnologyManager.IsInProgress(template.bottom));
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '||'; readers may interpret this as an expression boundary.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 337| »   »   »   var·template·=·cmpDataTemplateManager.GetTechnologyTemplate(templateName);
|    | [NORMAL] JSHintBear:
|    | 'template' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 381| »   »   »   var·cmpTrigger·=·Engine.QueryInterface(SYSTEM_ENTITY,·IID_Trigger);
|    | [NORMAL] JSHintBear:
|    | 'cmpTrigger' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 420| »   for·(var·i·=·0;·i·<·this.queue.length;·++i)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 782| »   »   »   »   »   var·cmpPlayer·=·QueryOwnerInterface(this.entity);
|    | [NORMAL] JSHintBear:
|    | 'cmpPlayer' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 793| »   »   »   var·cmpTechnologyManager·=·QueryOwnerInterface(this.entity,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 796| »   »   »   var·template·=·cmpTechnologyManager.GetTechnologyTemplate(item.technologyTemplate);
|    | [NORMAL] JSHintBear:
|    | 'template' is already defined.
leper added inline comments.
binaries/data/mods/public/simulation/components/Pack.js
99 ↗(On Diff #4091)

?

binaries/data/mods/public/simulation/components/ProductionQueue.js
516 ↗(On Diff #4091)

?

binaries/data/mods/public/simulation/components/Upgrade.js
277 ↗(On Diff #4091)

?

binaries/data/mods/public/simulation/helpers/Cheat.js
76 ↗(On Diff #4091)

The linter had something to say on this.

84 ↗(On Diff #4091)

We do tend to merge }); on one line.

And having this whole thing in a file would most likely be nicer to extend for modders, and we do already have cheat json files which could contain this. Or since we are moving to files already Auras suddenly seem quite close to what is wanted.

wraitii added inline comments.Nov 4 2017, 9:04 PM
binaries/data/mods/public/simulation/helpers/Cheat.js
84 ↗(On Diff #4091)

Well that's sort of the whole point. We could, I suppose, just adapt Auras so that everything is an aura instead of a modification, including technology effects, but I don't think that's the ideal solution over having a specific component for that (and auras can't currently be modded in from map files that easily iirc).

leper added inline comments.Nov 5 2017, 1:27 AM
binaries/data/mods/public/simulation/helpers/Cheat.js
84 ↗(On Diff #4091)

Still the point about this belonging into some sort of file still stands.

wraitii marked 3 inline comments as done.Jan 1 2019, 10:42 AM
wraitii added inline comments.
binaries/data/mods/public/l10n/fa.public-gui-userreport.po
7 ↗(On Diff #7174)

Messed up listing, won't be in the final patch.

binaries/data/mods/public/simulation/components/ProductionQueue.js
514 ↗(On Diff #7174)

Will fix™

binaries/data/mods/public/simulation/helpers/Cheat.js
77 ↗(On Diff #7174)

will fix™

Build failure - The Moirai have given mortals hearts that can endure.

Linter detected issues:
Executing section Default...
Executing section Source...
Executing section JS...

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 513| <<<<<<<·HEAD
|    | [MAJOR] ESLintBear:
|    | Parsing error: Unexpected token <<

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 190| »   for·(var·i·in·techList)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 192| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 202| »   for·(var·i·=·0;·i·<·techList.length;·i++)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 204| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 374| »   »   »   var·cmpTrigger·=·Engine.QueryInterface(SYSTEM_ENTITY,·IID_Trigger);
|    | [NORMAL] JSHintBear:
|    | 'cmpTrigger' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 513| <<<<<<<·HEAD
|    | [MAJOR] JSHintBear:
|    | Expected an identifier and instead saw '<<'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 513| <<<<<<<·HEAD
|    | [MAJOR] JSHintBear:
|    | Expected an operator and instead saw '<<'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 513| <<<<<<<·HEAD
|    | [MAJOR] JSHintBear:
|    | Expected an operator and instead saw '<<'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 513| <<<<<<<·HEAD
|    | [MAJOR] JSHintBear:
|    | Expected an operator and instead saw '<'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 513| <<<<<<<·HEAD
|    | [NORMAL] JSHintBear:
|    | Expected an assignment or function call and instead saw an expression.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 513| <<<<<<<·HEAD
|    | [MAJOR] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 513| <<<<<<<·HEAD
|    | [NORMAL] JSHintBear:
|    | Expected an assignment or function call and instead saw an expression.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 513| <<<<<<<·HEAD
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 515| =======
|    | [NORMAL] JSHintBear:
|    | Unreachable '===' after 'return'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 515| =======
|    | [MAJOR] JSHintBear:
|    | Expected an identifier and instead saw '==='.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 515| =======
|    | [MAJOR] JSHintBear:
|    | Expected an operator and instead saw '==='.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 515| =======
|    | [MAJOR] JSHintBear:
|    | Expected an operator and instead saw '='.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 515| =======
|    | [NORMAL] JSHintBear:
|    | Expected an assignment or function call and instead saw an expression.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 515| =======
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [NORMAL] JSHintBear:
|    | Unreachable '>>>' after 'return'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [MAJOR] JSHintBear:
|    | Expected an identifier and instead saw '>>>'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [MAJOR] JSHintBear:
|    | Expected an operator and instead saw '>>>'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [MAJOR] JSHintBear:
|    | Expected an operator and instead saw '>'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [NORMAL] JSHintBear:
|    | Expected an assignment or function call and instead saw an expression.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [MAJOR] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [MAJOR] JSHintBear:
|    | Expected an operator and instead saw '...'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [NORMAL] JSHintBear:
|    | Expected an assignment or function call and instead saw an expression.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [MAJOR] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [NORMAL] JSHintBear:
|    | Expected an assignment or function call and instead saw an expression.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [MAJOR] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [NORMAL] JSHintBear:
|    | Expected an assignment or function call and instead saw an expression.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [MAJOR] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [NORMAL] JSHintBear:
|    | Expected an assignment or function call and instead saw an expression.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [MAJOR] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [NORMAL] JSHintBear:
|    | Expected an assignment or function call and instead saw an expression.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [MAJOR] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [NORMAL] JSHintBear:
|    | Expected '(' and instead saw 'cheats'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [MAJOR] JSHintBear:
|    | Expected an identifier and instead saw '.'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 517| >>>>>>>·dd16e83248...·Use·the·modifications·manager·for·cheats.
|    | [MAJOR] JSHintBear:
|    | Line breaking error '.'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 518| };
|    | [NORMAL] JSHintBear:
|    | Expected ';' and instead saw '}'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 538| };
|    | [MAJOR] JSHintBear:
|    | Expected ')' to match '{b}' from line 517 and instead saw ';'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 772| »   »   »   »   »   var·cmpPlayer·=·QueryOwnerInterface(this.entity);
|    | [NORMAL] JSHintBear:
|    | 'cmpPlayer' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 783| »   »   »   var·cmpTechnologyManager·=·QueryOwnerInterface(this.entity,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 507| {
|    | [MAJOR] JSHintBear:
|    | Unmatched '{'.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 849| The line belonging to the following result cannot be printed because it refers to a line that doesn't seem to exist in the given file.
|    | [MAJOR] JSHintBear:
|    | Unrecoverable syntax error. (100% scanned).
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  75|  75| 		if (cmpModManager.HasAnyGlobalModificationWithID("cheat/fastactions"))
|  76|  76| 		{
|  77|  77| 			warn("here");
|  78|    |-			cmpModManager.RemoveGlobalModifications("cheat/fastactions")
|    |  78|+			cmpModManager.RemoveGlobalModifications("cheat/fastactions");
|  79|  79| 		}
|  80|  80| 		else
|  81|  81| 			cmpModManager.AddGlobalModifications("cheat/fastactions", 1000, {
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  79|  79| 		}
|  80|  80| 		else
|  81|  81| 			cmpModManager.AddGlobalModifications("cheat/fastactions", 1000, {
|  82|    |-					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  82|+				"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    | [NORMAL] ESLintBear (key-spacing):
|    | Extra space after key 'Cost/BuildTime'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  79|  79| 		}
|  80|  80| 		else
|  81|  81| 			cmpModManager.AddGlobalModifications("cheat/fastactions", 1000, {
|  82|    |-					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  82|+					"Cost/BuildTime": {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  79|  79| 		}
|  80|  80| 		else
|  81|  81| 			cmpModManager.AddGlobalModifications("cheat/fastactions", 1000, {
|  82|    |-					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  82|+					"Cost/BuildTime" : { "affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  79|  79| 		}
|  80|  80| 		else
|  81|  81| 			cmpModManager.AddGlobalModifications("cheat/fastactions", 1000, {
|  82|    |-					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  82|+					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01 },
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  80|  80| 		else
|  81|  81| 			cmpModManager.AddGlobalModifications("cheat/fastactions", 1000, {
|  82|  82| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|    |-					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|    |  83|+				"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|  86| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    | [NORMAL] ESLintBear (key-spacing):
|    | Extra space after key 'ResourceGatherer/BaseSpeed'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  80|  80| 		else
|  81|  81| 			cmpModManager.AddGlobalModifications("cheat/fastactions", 1000, {
|  82|  82| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|    |-					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|    |  83|+					"ResourceGatherer/BaseSpeed": {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|  86| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  80|  80| 		else
|  81|  81| 			cmpModManager.AddGlobalModifications("cheat/fastactions", 1000, {
|  82|  82| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|    |-					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|    |  83|+					"ResourceGatherer/BaseSpeed" : { "affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|  86| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  80|  80| 		else
|  81|  81| 			cmpModManager.AddGlobalModifications("cheat/fastactions", 1000, {
|  82|  82| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|    |-					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|    |  83|+					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0 },
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|  86| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  81|  81| 			cmpModManager.AddGlobalModifications("cheat/fastactions", 1000, {
|  82|  82| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|    |-					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  84|+				"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|  86| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  87|  87| 				}
|    | [NORMAL] ESLintBear (key-spacing):
|    | Extra space after key 'Pack/Time'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  81|  81| 			cmpModManager.AddGlobalModifications("cheat/fastactions", 1000, {
|  82|  82| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|    |-					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  84|+					"Pack/Time": {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|  86| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  87|  87| 				}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  81|  81| 			cmpModManager.AddGlobalModifications("cheat/fastactions", 1000, {
|  82|  82| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|    |-					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  84|+					"Pack/Time" : { "affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|  86| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  87|  87| 				}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  81|  81| 			cmpModManager.AddGlobalModifications("cheat/fastactions", 1000, {
|  82|  82| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|    |-					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  84|+					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01 },
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|  86| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  87|  87| 				}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  82|  82| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|    |-					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  85|+				"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|  86| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  87|  87| 				}
|  88|  88| 			);
|    | [NORMAL] ESLintBear (key-spacing):
|    | Extra space after key 'Upgrade/Time'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  82|  82| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|    |-					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  85|+					"Upgrade/Time": {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|  86| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  87|  87| 				}
|  88|  88| 			);
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  82|  82| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|    |-					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  85|+					"Upgrade/Time" : { "affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|  86| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  87|  87| 				}
|  88|  88| 			);
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  82|  82| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|    |-					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  85|+					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01 },
|  86|  86| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  87|  87| 				}
|  88|  88| 			);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|    |-					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    |  86|+				"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  87|  87| 				}
|  88|  88| 			);
|  89|  89| 		return;
|    | [NORMAL] ESLintBear (key-spacing):
|    | Extra space after key 'ProductionQueue/TechCostMultiplier/time'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|    |-					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    |  86|+					"ProductionQueue/TechCostMultiplier/time": {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  87|  87| 				}
|  88|  88| 			);
|  89|  89| 		return;
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|    |-					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    |  86|+					"ProductionQueue/TechCostMultiplier/time" : { "affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  87|  87| 				}
|  88|  88| 			);
|  89|  89| 		return;
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  83|  83| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|    |-					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    |  86|+					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01 }
|  87|  87| 				}
|  88|  88| 			);
|  89|  89| 		return;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  84|  84| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  85|  85| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  86|  86| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  87|    |-				}
|    |  87|+			}
|  88|  88| 			);
|  89|  89| 		return;
|  90|  90| 	case "changespeed":

binaries/data/mods/public/simulation/helpers/Cheat.js
|  78| »   »   »   cmpModManager.RemoveGlobalModifications("cheat/fastactions")
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/helpers/Cheat.js
| 119| »   »   var·cmpTechnologyManager·=·Engine.QueryInterface(playerEnt,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.

binaries/data/mods/public/simulation/helpers/Cheat.js
| 126| »   »   »   var·cmpProductionQueue·=·Engine.QueryInterface(input.selected[0],·IID_ProductionQueue);
|    | [NORMAL] JSHintBear:
|    | 'cmpProductionQueue' is already defined.

binaries/data/mods/public/simulation/components/Player.js
| 378| »   for·(var·type·in·amounts)
|    | [NORMAL] JSHintBear:
|    | 'type' is already defined.

Link to build: https://jenkins.wildfiregames.com/job/differential/869/

Stan added a subscriber: Stan.Jan 1 2019, 10:52 AM

Some simple comments :)

binaries/data/mods/public/simulation/components/Pack.js
101 ↗(On Diff #7174)

I don't think we need the line above anymore.

binaries/data/mods/public/simulation/components/ProductionQueue.js
345 ↗(On Diff #7174)

Whitespace

binaries/data/mods/public/simulation/components/Upgrade.js
278 ↗(On Diff #7174)

remove :)

binaries/data/mods/public/simulation/helpers/Cheat.js
75 ↗(On Diff #7174)

Newline maybe ? No strong feelings.

wraitii updated this revision to Diff 7230.Jan 3 2019, 9:44 PM

Rebased and actually functional this time.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  74|  74| 			return;
|  75|  75| 
|  76|  76| 		if (cmpModManager.HasAnyModif("cheat/fastactions"))
|  77|    |-			cmpModManager.RemoveModifs("cheat/fastactions")
|    |  77|+			cmpModManager.RemoveModifs("cheat/fastactions");
|  78|  78| 		else
|  79|  79| 			cmpModManager.AddModifs("cheat/fastactions", {
|  80|  80| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  77|  77| 			cmpModManager.RemoveModifs("cheat/fastactions")
|  78|  78| 		else
|  79|  79| 			cmpModManager.AddModifs("cheat/fastactions", {
|  80|    |-					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  80|+				"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    | [NORMAL] ESLintBear (key-spacing):
|    | Extra space after key 'Cost/BuildTime'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  77|  77| 			cmpModManager.RemoveModifs("cheat/fastactions")
|  78|  78| 		else
|  79|  79| 			cmpModManager.AddModifs("cheat/fastactions", {
|  80|    |-					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  80|+					"Cost/BuildTime": {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  77|  77| 			cmpModManager.RemoveModifs("cheat/fastactions")
|  78|  78| 		else
|  79|  79| 			cmpModManager.AddModifs("cheat/fastactions", {
|  80|    |-					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  80|+					"Cost/BuildTime" : { "affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  77|  77| 			cmpModManager.RemoveModifs("cheat/fastactions")
|  78|  78| 		else
|  79|  79| 			cmpModManager.AddModifs("cheat/fastactions", {
|  80|    |-					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  80|+					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01 },
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  78|  78| 		else
|  79|  79| 			cmpModManager.AddModifs("cheat/fastactions", {
|  80|  80| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|    |-					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|    |  81|+				"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|  84| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    | [NORMAL] ESLintBear (key-spacing):
|    | Extra space after key 'ResourceGatherer/BaseSpeed'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  78|  78| 		else
|  79|  79| 			cmpModManager.AddModifs("cheat/fastactions", {
|  80|  80| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|    |-					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|    |  81|+					"ResourceGatherer/BaseSpeed": {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|  84| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  78|  78| 		else
|  79|  79| 			cmpModManager.AddModifs("cheat/fastactions", {
|  80|  80| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|    |-					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|    |  81|+					"ResourceGatherer/BaseSpeed" : { "affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|  84| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  78|  78| 		else
|  79|  79| 			cmpModManager.AddModifs("cheat/fastactions", {
|  80|  80| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|    |-					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|    |  81|+					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0 },
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|  84| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  79|  79| 			cmpModManager.AddModifs("cheat/fastactions", {
|  80|  80| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|    |-					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  82|+				"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|  84| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  85|  85| 				}
|    | [NORMAL] ESLintBear (key-spacing):
|    | Extra space after key 'Pack/Time'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  79|  79| 			cmpModManager.AddModifs("cheat/fastactions", {
|  80|  80| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|    |-					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  82|+					"Pack/Time": {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|  84| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  85|  85| 				}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  79|  79| 			cmpModManager.AddModifs("cheat/fastactions", {
|  80|  80| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|    |-					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  82|+					"Pack/Time" : { "affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|  84| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  85|  85| 				}
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  79|  79| 			cmpModManager.AddModifs("cheat/fastactions", {
|  80|  80| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|    |-					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  82|+					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01 },
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|  84| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  85|  85| 				}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  80|  80| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|    |-					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  83|+				"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|  84| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  85|  85| 				}
|  86|  86| 			);
|    | [NORMAL] ESLintBear (key-spacing):
|    | Extra space after key 'Upgrade/Time'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  80|  80| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|    |-					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  83|+					"Upgrade/Time": {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|  84| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  85|  85| 				}
|  86|  86| 			);
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  80|  80| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|    |-					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  83|+					"Upgrade/Time" : { "affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|  84| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  85|  85| 				}
|  86|  86| 			);
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  80|  80| 					"Cost/BuildTime" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|    |-					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|    |  83|+					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01 },
|  84|  84| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  85|  85| 				}
|  86|  86| 			);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|    |-					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    |  84|+				"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  85|  85| 				}
|  86|  86| 			);
|  87|  87| 		return;
|    | [NORMAL] ESLintBear (key-spacing):
|    | Extra space after key 'ProductionQueue/TechCostMultiplier/time'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|    |-					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    |  84|+					"ProductionQueue/TechCostMultiplier/time": {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  85|  85| 				}
|  86|  86| 			);
|  87|  87| 		return;
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required after '{'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|    |-					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    |  84|+					"ProductionQueue/TechCostMultiplier/time" : { "affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  85|  85| 				}
|  86|  86| 			);
|  87|  87| 		return;
|    | [NORMAL] ESLintBear (object-curly-spacing):
|    | A space is required before '}'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  81|  81| 					"ResourceGatherer/BaseSpeed" : {"affects": [["Structure"], ["Unit"]], "multiply": 1000.0},
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|    |-					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|    |  84|+					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01 }
|  85|  85| 				}
|  86|  86| 			);
|  87|  87| 		return;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/helpers/Cheat.js
|  82|  82| 					"Pack/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  83|  83| 					"Upgrade/Time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01},
|  84|  84| 					"ProductionQueue/TechCostMultiplier/time" : {"affects": [["Structure"], ["Unit"]], "multiply": 0.01}
|  85|    |-				}
|    |  85|+			}
|  86|  86| 			);
|  87|  87| 		return;
|  88|  88| 	case "changespeed":

binaries/data/mods/public/simulation/helpers/Cheat.js
|  77| »   »   »   cmpModManager.RemoveModifs("cheat/fastactions")
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/helpers/Cheat.js
| 117| »   »   var·cmpTechnologyManager·=·Engine.QueryInterface(playerEnt,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.

binaries/data/mods/public/simulation/helpers/Cheat.js
| 124| »   »   »   var·cmpProductionQueue·=·Engine.QueryInterface(input.selected[0],·IID_ProductionQueue);
|    | [NORMAL] JSHintBear:
|    | 'cmpProductionQueue' is already defined.
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'techCostMultiplier'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/ProductionQueue.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/ProductionQueue.js
| 342| 342| 
| 343| 343| 			let template = TechnologyTemplates.Get(templateName);
| 344| 344| 			let techCostMultiplier = this.GetTechCostMultiplier();
| 345|    |-			let time =  techCostMultiplier.time * template.researchTime;
|    | 345|+			let time = techCostMultiplier.time * template.researchTime;
| 346| 346| 
| 347| 347| 			let cost = {};
| 348| 348| 			for (let res in template.cost)
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'for-of'.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/ProductionQueue.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/ProductionQueue.js
| 472| 472| {
| 473| 473| 	var out = [];
| 474| 474| 	for (var item of this.queue)
| 475|    |-	{
|    | 475|+	
| 476| 476| 		out.push({
| 477| 477| 			"id": item.id,
| 478| 478| 			"unitTemplate": item.unitTemplate,
| 483| 483| 			"timeRemaining": item.timeRemaining,
| 484| 484| 			"metadata": item.metadata,
| 485| 485| 		});
| 486|    |-	}
|    | 486|+	
| 487| 487| 	return out;
| 488| 488| };
| 489| 489| 
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/ProductionQueue.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/ProductionQueue.js
| 565| 565| 	var spawnedEnts = [];
| 566| 566| 
| 567| 567| 	if (this.entityCache.length == 0)
| 568|    |-	{
|    | 568|+	
| 569| 569| 		// We need entities to test spawning, but we don't want to waste resources,
| 570| 570| 		//	so only create them once and use as needed
| 571| 571| 		for (var i = 0; i < count; ++i)
| 584| 584| 				cmpPlayerEntityLimits.ChangeCount(unitCategory, -1);
| 585| 585| 			}
| 586| 586| 		}
| 587|    |-	}
|    | 587|+	
| 588| 588| 
| 589| 589| 	let cmpAutoGarrison;
| 590| 590| 	if (cmpRallyPoint)
|    | [NORMAL] ESLintBear (curly):
|    | Unnecessary { after 'if' condition.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/ProductionQueue.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/ProductionQueue.js
| 645| 645| 	}
| 646| 646| 
| 647| 647| 	if (spawnedEnts.length > 0 && !cmpAutoGarrison)
| 648|    |-	{
|    | 648|+	
| 649| 649| 		// If a rally point is set, walk towards it (in formation) using a suitable command based on where the
| 650| 650| 		// rally point is placed.
| 651| 651| 		if (cmpRallyPoint)
| 658| 658| 					ProcessCommand(cmpOwnership.GetOwner(), com);
| 659| 659| 			}
| 660| 660| 		}
| 661|    |-	}
|    | 661|+	
| 662| 662| 
| 663| 663| 	if (createdEnts.length > 0)
| 664| 664| 		Engine.PostMessage(this.entity, MT_TrainingFinished, {

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 343| »   »   »   let·template·=·TechnologyTemplates.Get(templateName);
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'template' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 345| »   »   »   let·time·=··techCostMultiplier.time·*·template.researchTime;
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'time' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 597| »   for·(let·i·=·0;·i·<·count;·++i)
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'i' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 599| »   »   let·ent·=·this.entityCache[0];
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'ent' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 782| »   »   »   let·template·=·TechnologyTemplates.Get(item.technologyTemplate);
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'template' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 190| »   for·(var·i·in·techList)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 192| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 202| »   for·(var·i·=·0;·i·<·techList.length;·i++)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 204| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 374| »   »   »   var·cmpTrigger·=·Engine.QueryInterface(SYSTEM_ENTITY,·IID_Trigger);
|    | [NORMAL] JSHintBear:
|    | 'cmpTrigger' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 768| »   »   »   »   »   var·cmpPlayer·=·QueryOwnerInterface(this.entity);
|    | [NORMAL] JSHintBear:
|    | 'cmpPlayer' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 779| »   »   »   var·cmpTechnologyManager·=·QueryOwnerInterface(this.entity,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.

binaries/data/mods/public/simulation/components/Player.js
| 378| »   for·(var·type·in·amounts)
|    | [NORMAL] JSHintBear:
|    | 'type' is already defined.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/differential/898/

wraitii updated this revision to Diff 9469.Aug 24 2019, 10:02 AM
wraitii retitled this revision from Update the fast-actions cheat to use the modifications manager to Update the fast-actions cheat to use the modifiers manager.

Rebased following commit of D274 in rP22767.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'techCostMultiplier'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/ProductionQueue.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/ProductionQueue.js
| 335| 335| 
| 336| 336| 			let template = TechnologyTemplates.Get(templateName);
| 337| 337| 			let techCostMultiplier = this.GetTechCostMultiplier();
| 338|    |-			let time =  techCostMultiplier.time * template.researchTime;
|    | 338|+			let time = techCostMultiplier.time * template.researchTime;
| 339| 339| 
| 340| 340| 			let cost = {};
| 341| 341| 			for (let res in template.cost)

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 771| »   »   »   let·template·=·TechnologyTemplates.Get(item.technologyTemplate);
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'template' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 190| »   for·(var·i·in·techList)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 192| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 202| »   for·(var·i·=·0;·i·<·techList.length;·i++)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 204| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 757| »   »   »   »   »   var·cmpPlayer·=·QueryOwnerInterface(this.entity);
|    | [NORMAL] JSHintBear:
|    | 'cmpPlayer' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 768| »   »   »   var·cmpTechnologyManager·=·QueryOwnerInterface(this.entity,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.

binaries/data/mods/public/simulation/components/Player.js
| 378| »   for·(var·type·in·amounts)
|    | [NORMAL] JSHintBear:
|    | 'type' is already defined.

binaries/data/mods/public/simulation/helpers/Cheat.js
| 116| »   »   var·cmpTechnologyManager·=·Engine.QueryInterface(playerEnt,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.

binaries/data/mods/public/simulation/helpers/Cheat.js
| 123| »   »   »   var·cmpProductionQueue·=·Engine.QueryInterface(input.selected[0],·IID_ProductionQueue);
|    | [NORMAL] JSHintBear:
|    | 'cmpProductionQueue' is already defined.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/467/display/redirect

wraitii updated this revision to Diff 9470.Aug 24 2019, 10:17 AM
wraitii retitled this revision from Update the fast-actions cheat to use the modifiers manager to Update the fast-actions cheat and AI bonuses to use the modifiers manager.

Also update AI and remove the Player interface there.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...

binaries/data/mods/public/simulation/helpers/Cheat.js
| 113| »   »   var·cmpTechnologyManager·=·Engine.QueryInterface(playerEnt,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.

binaries/data/mods/public/simulation/helpers/Cheat.js
| 120| »   »   »   var·cmpProductionQueue·=·Engine.QueryInterface(input.selected[0],·IID_ProductionQueue);
|    | [NORMAL] JSHintBear:
|    | 'cmpProductionQueue' is already defined.
|    | [NORMAL] ESLintBear (comma-spacing):
|    | A space is required after ','.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/helpers/Player.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/helpers/Player.js
| 323| 323| 	return IsOwnedByHelper(player, target, "IsMutualAlly");
| 324| 324| }
| 325| 325| 
| 326|    |-function IsOwnedByNeutralOfPlayer(player,target)
|    | 326|+function IsOwnedByNeutralOfPlayer(player, target)
| 327| 327| {
| 328| 328| 	return IsOwnedByHelper(player, target, "IsNeutral");
| 329| 329| }

binaries/data/mods/public/simulation/helpers/Player.js
|  78| »   »   let·cmpPlayer·=·QueryPlayerIDInterface(i);
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'cmpPlayer' is already declared in the upper scope.

binaries/data/mods/public/simulation/helpers/Player.js
| 155| »   »   for·(let·i·=·0;·i·<·numPlayers;·++i)
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'i' is already declared in the upper scope.

binaries/data/mods/public/simulation/helpers/Player.js
|  67| »   »   var·entID·=·cmpPlayerManager.GetPlayerByID(i);
|    | [NORMAL] JSHintBear:
|    | 'entID' is already defined.

binaries/data/mods/public/simulation/helpers/Player.js
|  76| »   for·(var·i·=·0;·i·<·numPlayers;·++i)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/helpers/Player.js
| 133| »   »   »   for·(var·j·=·0;·j·<·numPlayers;·++j)
|    | [NORMAL] JSHintBear:
|    | 'j' is already defined.
|    | [NORMAL] ESLintBear (no-multi-spaces):
|    | Multiple spaces found before 'techCostMultiplier'.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/ProductionQueue.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/ProductionQueue.js
| 335| 335| 
| 336| 336| 			let template = TechnologyTemplates.Get(templateName);
| 337| 337| 			let techCostMultiplier = this.GetTechCostMultiplier();
| 338|    |-			let time =  techCostMultiplier.time * template.researchTime;
|    | 338|+			let time = techCostMultiplier.time * template.researchTime;
| 339| 339| 
| 340| 340| 			let cost = {};
| 341| 341| 			for (let res in template.cost)

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 771| »   »   »   let·template·=·TechnologyTemplates.Get(item.technologyTemplate);
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'template' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 190| »   for·(var·i·in·techList)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 192| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 202| »   for·(var·i·=·0;·i·<·techList.length;·i++)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 204| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 757| »   »   »   »   »   var·cmpPlayer·=·QueryOwnerInterface(this.entity);
|    | [NORMAL] JSHintBear:
|    | 'cmpPlayer' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 768| »   »   »   var·cmpTechnologyManager·=·QueryOwnerInterface(this.entity,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.

binaries/data/mods/public/simulation/components/tests/test_Pack.js
|  42| »   "SetInterval":·(ent,·iid,·funcname,·time,·repeattime,·data)·=>·{·timerActivated·=·true;·return·7;·}
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'ent' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/tests/test_UpgradeModification.js
|  92| »   "ApplyTemplateModifiers":·(valueName,·curValue,·template,·player)·=>·{
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'template' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/Player.js
| 344| »   for·(var·type·in·amounts)
|    | [NORMAL] JSHintBear:
|    | 'type' is already defined.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/468/display/redirect

Freagarach added inline comments.
binaries/data/mods/public/simulation/components/ProductionQueue.js
516 ↗(On Diff #4091)

Next to @Stan's comments, this is redundant also.

wraitii updated this revision to Diff 9564.Sep 1 2019, 9:54 AM

Remove now useless player calls.

binaries/data/mods/public/simulation/helpers/Cheat.js
84 ↗(On Diff #4091)

Point considered : currently the data transmitted for cheats is hardcoded in the GUI (haven't bothered finding why just yet), making this a bigger breaking change than I intend with this diff, so it'll have to come later.

Similarly, AI handicap could be put in a JSON file, but not done yet.

binaries/data/mods/public/simulation/helpers/Player.js
98 ↗(On Diff #9470)

Deleted for not being useful, since it's indeed trivial to do that and AI code can be adapted.

Vulcan added a comment.Sep 1 2019, 9:56 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/24/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (comma-spacing):
|    | A space is required after ','.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/helpers/Player.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/helpers/Player.js
| 323| 323| 	return IsOwnedByHelper(player, target, "IsMutualAlly");
| 324| 324| }
| 325| 325| 
| 326|    |-function IsOwnedByNeutralOfPlayer(player,target)
|    | 326|+function IsOwnedByNeutralOfPlayer(player, target)
| 327| 327| {
| 328| 328| 	return IsOwnedByHelper(player, target, "IsNeutral");
| 329| 329| }

binaries/data/mods/public/simulation/helpers/Player.js
|  78| »   »   let·cmpPlayer·=·QueryPlayerIDInterface(i);
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'cmpPlayer' is already declared in the upper scope.

binaries/data/mods/public/simulation/helpers/Player.js
| 155| »   »   for·(let·i·=·0;·i·<·numPlayers;·++i)
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'i' is already declared in the upper scope.

binaries/data/mods/public/simulation/helpers/Player.js
|  67| »   »   var·entID·=·cmpPlayerManager.GetPlayerByID(i);
|    | [NORMAL] JSHintBear:
|    | 'entID' is already defined.

binaries/data/mods/public/simulation/helpers/Player.js
|  76| »   for·(var·i·=·0;·i·<·numPlayers;·++i)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/helpers/Player.js
| 133| »   »   »   for·(var·j·=·0;·j·<·numPlayers;·++j)
|    | [NORMAL] JSHintBear:
|    | 'j' is already defined.

binaries/data/mods/public/simulation/components/Player.js
| 344| »   for·(var·type·in·amounts)
|    | [NORMAL] JSHintBear:
|    | 'type' is already defined.

binaries/data/mods/public/simulation/helpers/Cheat.js
| 113| »   »   var·cmpTechnologyManager·=·Engine.QueryInterface(playerEnt,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.

binaries/data/mods/public/simulation/helpers/Cheat.js
| 120| »   »   »   var·cmpProductionQueue·=·Engine.QueryInterface(input.selected[0],·IID_ProductionQueue);
|    | [NORMAL] JSHintBear:
|    | 'cmpProductionQueue' is already defined.

binaries/data/mods/public/simulation/components/tests/test_Pack.js
|  42| »   "SetInterval":·(ent,·iid,·funcname,·time,·repeattime,·data)·=>·{·timerActivated·=·true;·return·7;·}
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'ent' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 767| »   »   »   let·template·=·TechnologyTemplates.Get(item.technologyTemplate);
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'template' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 190| »   for·(var·i·in·techList)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 192| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 202| »   for·(var·i·=·0;·i·<·techList.length;·i++)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 204| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 753| »   »   »   »   »   var·cmpPlayer·=·QueryOwnerInterface(this.entity);
|    | [NORMAL] JSHintBear:
|    | 'cmpPlayer' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 764| »   »   »   var·cmpTechnologyManager·=·QueryOwnerInterface(this.entity,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.

binaries/data/mods/public/simulation/components/tests/test_UpgradeModification.js
|  92| »   "ApplyTemplateModifiers":·(valueName,·curValue,·template,·player)·=>·{
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'template' is already declared in the upper scope.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/533/display/redirect

Stan added inline comments.Sep 1 2019, 10:58 AM
binaries/data/mods/public/simulation/helpers/Cheat.js
73 ↗(On Diff #9564)

Do you need to check for system entities ?

binaries/data/mods/public/simulation/helpers/Player.js
98 ↗(On Diff #9564)

Create a ticket ?

binaries/data/mods/public/simulation/helpers/TraderGain.js
30 ↗(On Diff #9564)

Capital C :)

wraitii updated this revision to Diff 9899.Sep 22 2019, 9:21 AM

Stan's comments

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/276/display/redirect

wraitii added inline comments.Sep 22 2019, 9:38 AM
binaries/data/mods/public/simulation/helpers/Cheat.js
73 ↗(On Diff #9564)

Generally we assume no, so I'll remove this.

binaries/data/mods/public/simulation/helpers/Player.js
98 ↗(On Diff #9564)

meh.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...

binaries/data/mods/public/simulation/helpers/Cheat.js
| 110| »   »   var·cmpTechnologyManager·=·Engine.QueryInterface(playerEnt,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.

binaries/data/mods/public/simulation/helpers/Cheat.js
| 117| »   »   »   var·cmpProductionQueue·=·Engine.QueryInterface(input.selected[0],·IID_ProductionQueue);
|    | [NORMAL] JSHintBear:
|    | 'cmpProductionQueue' is already defined.

binaries/data/mods/public/simulation/components/Player.js
| 344| »   for·(var·type·in·amounts)
|    | [NORMAL] JSHintBear:
|    | 'type' is already defined.

binaries/data/mods/public/simulation/components/tests/test_UpgradeModification.js
|  92| »   "ApplyTemplateModifiers":·(valueName,·curValue,·template,·player)·=>·{
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'template' is already declared in the upper scope.
|    | [NORMAL] ESLintBear (comma-spacing):
|    | A space is required after ','.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/helpers/Player.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/helpers/Player.js
| 323| 323| 	return IsOwnedByHelper(player, target, "IsMutualAlly");
| 324| 324| }
| 325| 325| 
| 326|    |-function IsOwnedByNeutralOfPlayer(player,target)
|    | 326|+function IsOwnedByNeutralOfPlayer(player, target)
| 327| 327| {
| 328| 328| 	return IsOwnedByHelper(player, target, "IsNeutral");
| 329| 329| }

binaries/data/mods/public/simulation/helpers/Player.js
|  78| »   »   let·cmpPlayer·=·QueryPlayerIDInterface(i);
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'cmpPlayer' is already declared in the upper scope.

binaries/data/mods/public/simulation/helpers/Player.js
| 155| »   »   for·(let·i·=·0;·i·<·numPlayers;·++i)
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'i' is already declared in the upper scope.

binaries/data/mods/public/simulation/helpers/Player.js
|  67| »   »   var·entID·=·cmpPlayerManager.GetPlayerByID(i);
|    | [NORMAL] JSHintBear:
|    | 'entID' is already defined.

binaries/data/mods/public/simulation/helpers/Player.js
|  76| »   for·(var·i·=·0;·i·<·numPlayers;·++i)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/helpers/Player.js
| 133| »   »   »   for·(var·j·=·0;·j·<·numPlayers;·++j)
|    | [NORMAL] JSHintBear:
|    | 'j' is already defined.

binaries/data/mods/public/simulation/components/tests/test_Pack.js
|  42| »   "SetInterval":·(ent,·iid,·funcname,·time,·repeattime,·data)·=>·{·timerActivated·=·true;·return·7;·}
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'ent' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 767| »   »   »   let·template·=·TechnologyTemplates.Get(item.technologyTemplate);
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'template' is already declared in the upper scope.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 190| »   for·(var·i·in·techList)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 192| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 202| »   for·(var·i·=·0;·i·<·techList.length;·i++)
|    | [NORMAL] JSHintBear:
|    | 'i' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 204| »   »   var·tech·=·techList[i];
|    | [NORMAL] JSHintBear:
|    | 'tech' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 753| »   »   »   »   »   var·cmpPlayer·=·QueryOwnerInterface(this.entity);
|    | [NORMAL] JSHintBear:
|    | 'cmpPlayer' is already defined.

binaries/data/mods/public/simulation/components/ProductionQueue.js
| 764| »   »   »   var·cmpTechnologyManager·=·QueryOwnerInterface(this.entity,·IID_TechnologyManager);
|    | [NORMAL] JSHintBear:
|    | 'cmpTechnologyManager' is already defined.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/788/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Sep 22 2019, 9:46 AM
This revision was automatically updated to reflect the committed changes.