Differential D1023
Improves the replay list interface Authored by vladislavbelov on Nov 7 2017, 10:22 PM.
Details
Comparison:
Why the Summary button logic was changed? Why Delete and Reload cache buttons were swapped? Why the padding was changed?
Diff Detail
Event TimelineComment Actions Successful build - Chance fights ever on the side of the prudent. Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Checking XML files... Comment Actions Looks nice, besides the buttons: They are huge in fullscreen on a Full-HD monitor. So I think a constant size would be better. Also the gap between two buttons is too small for my perception.  Comment Actions (We also discussed moving to the red buttons in https://wildfiregames.com/forum/index.php?/topic/22791-replace-stone-buttons-with-red-ones/ in caes you want to go for that) Comment Actions Yeah, I saw it. I have thoughts, I'll make a post at the weekend about the GUI style. Ok, I'll try it. Comment Actions Successful build - Chance fights ever on the side of the prudent. Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Checking XML files... Comment Actions I've been looking at a couple changes in general, so I thought I'd mention them.  The first is in a lot of the scroll boxes the text goes over the bottom bar. This can be fixed by adjusting the z-value in the associated sprite. The second is the black border around the scrollbar, which looks kind of weird. In dropdown scrollbars it looks fine, because the dropdown has a black border too. But for regular scrollbars it looks out of place, to me anyway. We can create another scrollbar to fix this, but there's still problems with the dropdowns because the text can cover the black borders. 
Comment Actions (That text of the table (COList.cpp) is rendered above the sprite is hardcoded in that c++ file IIRC. If that can be fixed with a z index please upload a diff, but until now multiple people left that issue with annoyance)
Comment Actions These things should be fixed in the C++ part, as elexis mentioned. Not in GUI style things.
Comment Actions This is what I had in mind. Index: binaries/data/mods/mod/gui/common/modern/sprites.xml =================================================================== --- binaries/data/mods/mod/gui/common/modern/sprites.xml (revision 20434) +++ binaries/data/mods/mod/gui/common/modern/sprites.xml (working copy) @@ -221,6 +221,7 @@ <image texture = "global/modern/gold-separator.png" real_texture_placement = "0 0 806 1" size = "0 100%-1 100% 100%" + z_level = "15" /> <image backcolor = "12 12 12 100" size = "0 0 100% 100%-1"  Comment Actions If it only needs a COList.cpp change, it should be easy. IIRC fpre / ffffffff had a WIP diff for that somewhere. Comment Actions I agree that this looks ugly in   I suppose the math wasn't done right to always have the grid.
Good catch! (Historic reasons...) Button swap makes sense. So basically the patch advertizement is accepted, the other things mentioned here are offtopic, code looks okay, but I don't want to test it nor want to look at the size math (so I can't tell whether it actually implements what it claims to). So you could commit as agreed with me or something (some word X where nothing < X < review) if you think the numbers are better (and if they actually are for all relevant window sizes). We also want to use the Red buttons, so all GUI pages use the same button style (although I found/find grey ones more appealing sometimes) (the patch can be considered one of multiple independent improvements of something that is free of big defects.) (We should have a ticket and a good reference to this patch with regards to the golden bar thing) Comment Actions I agree, we need to define something like a UI conventions, what & where & which elements do we use in different cases. | ||||||||||||||||||||||||||||||||||||||||||||||
