Created a generic template for the kennel, as it's not inconceivable other factions might have them in the future (cf. elephant stables).
Details
Details
Test if everything works
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Checking XML files... Relax-NG validity error : Extra element props in interleave /public/art/actors/structures/carthaginians/stable_elephant.xml:0: Relax-NG validity error : Element variant failed to validate content /public/art/actors/structures/carthaginians/stable_elephant.xml:0: Relax-NG validity error : Element group has extra content: variant Relax-NG validity error : Extra element group in interleave /public/art/actors/structures/carthaginians/stable_elephant.xml:0: Relax-NG validity error : Element actor failed to validate content
Comment Actions
I suppose this patch could be useful for modders.
| binaries/data/mods/public/simulation/templates/template_structure_military_kennel.xml | ||
|---|---|---|
| 4–10 ↗ | (On Diff #4188) | no idea why, but we seem to be using the convention to put .0 behind those values, probably it is some random artefact though |
| 19–20 ↗ | (On Diff #4188) | the original parent template had a metal cost too, so that should be added here |
| 41 ↗ | (On Diff #4188) | some classes like military are added, not a problem imo (as stables and stuff are military too, this seems rather military too) |
| binaries/data/mods/public/simulation/templates/structures/brit_kennel.xml | ||
|---|---|---|
| 37 ↗ | (On Diff #4188) | Specific name can stay here |
| binaries/data/mods/public/simulation/templates/template_structure_military_kennel.xml | ||
|---|---|---|
| 46 ↗ | (On Diff #4188) | also wondering why there is no selectiongroupname |
| binaries/data/mods/public/simulation/templates/structures/brit_kennel.xml | ||
|---|---|---|
| 37 ↗ | (On Diff #4188) | It has no added value, as it's identical to the parent's generic name. But if you think it should stay, I'll add it here. |
| binaries/data/mods/public/simulation/templates/template_structure_military_kennel.xml | ||
| 4–10 ↗ | (On Diff #4188) | If it's a convention, it's not done consistently, cf. template_structure_civic_civil_centre.xml |
| 19–20 ↗ | (On Diff #4188) | Good point! I'll correct this. |
| 46 ↗ | (On Diff #4188) | Structure templates don't have a selectiongroupname, cf. template_structure_military_barracks.xml |
| binaries/data/mods/public/simulation/templates/structures/brit_kennel.xml | ||
|---|---|---|
| 37 ↗ | (On Diff #4188) | It should since the specific name is the name in the civs language, its just coincidence the is the same as the genericname (maybe it is even the wrong word but then ppl know where to change it) |
| binaries/data/mods/public/simulation/templates/template_structure_military_kennel.xml | ||
| 4–10 ↗ | (On Diff #4188) | I assume it is a ancient remnant of the times with discrete health and stuff, and thus can be removed => ok |
| 46 ↗ | (On Diff #4188) | So brit_kennel.xml should have one? |
| binaries/data/mods/public/simulation/templates/structures/brit_kennel.xml | ||
|---|---|---|
| 37 ↗ | (On Diff #4188) | OK, then I'll reinsert this line. |
| binaries/data/mods/public/simulation/templates/template_structure_military_kennel.xml | ||
| 46 ↗ | (On Diff #4188) | No, “unit”; the kennel is a structure and can't promote. brit_war_dog_b.xml should have (and has; that file isn't affected by this patch). |
| binaries/data/mods/public/simulation/templates/template_structure_military_kennel.xml | ||
|---|---|---|
| 46 ↗ | (On Diff #4188) | Ahh right, getting it => ok |