Page MenuHomeWildfire Games

Use US time/date formats for default
Needs ReviewPublic

Authored by temple on Nov 22 2017, 6:40 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

The default language is US English, so the date and time formats should be as well.
Hopefully the comments will give translators enough of a hint.

Test Plan

See D795 as well.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

elexis added a subscriber: elexis.Dec 5 2017, 6:53 PM

Not a fan of introducing an unused function and then the calls afterwards. Makes it harder to find possible improvements.

temple added a comment.Dec 5 2017, 7:04 PM
In D1054#44275, @elexis wrote:

Not a fan of introducing an unused function and then the calls afterwards. Makes it harder to find possible improvements.

This is meant after D795, to change from UK format to US format.
leper had comments there saying we should have an international English format and then US can have its own translations. I'm not sure all the details will work out, but that should be the first approach rather than this patch.

elexis added a comment.Dec 5 2017, 7:10 PM

Wait, we're talking about changing the default english strings from en_US to some international english (what definition?), then the scope of the change would be global.
Then all english strings have to be rechecked and translated to "international english", not only these 4 functions.

Also leper mentioned:

if you find someone that will and sees the possible confusion for most (all?) other translations as worth it, I'll not complain.

In D1054#44294, @elexis wrote:

Wait, we're talking about changing the default english strings from en_US to some international english (what definition?), then the scope of the change would be global.
Then all english strings have to be rechecked and translated to "international english", not only these 4 functions.
Also leper mentioned:

if you find someone that will and sees the possible confusion for most (all?) other translations as worth it, I'll not complain.

Are you that person?