Page MenuHomeWildfire Games

More buttons for lobby
Needs ReviewPublic

Authored by ffffffff on Nov 22 2017, 12:20 PM.

Details

Reviewers
elexis
Trac Tickets
#4858
Summary

I got now many demands from players for wanting to have especially replays in lobby as option. Also the last summary from a game should be available as option in lobby. Therefore the buttons below chat input are told to look appealing from players (@mapkoc, @Hannibal_Barca and more). So also having a button for options (changing settings in general and for lobby ofc) and for looking up history or civilization's info as button should be good (also if you want to talk about these things too).

Also go into replay without leaving lobby should be possible in conjunction with lobby overlay (D817), so we can look into lobby, while in a replay (not missing anything :) ).

Last Summary is in D854.

More Buttons Bar can be disabled, hidden or always visible. When hidden option is applied, it gets shown, when hovering with the mouse pointer below the chat input.

Normal lobby

Buttons bar shows up on pointer hover area on bottom of window

Options

Civs info is actualy hard to see but its opened guiPush from lobby.

Replays menu from lobby opened as dialog.

Test Plan

test

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Nov 22 2017, 12:20 PM
ffffffff edited the summary of this revision. (Show Details)
ffffffff updated the Trac tickets for this revision.
ffffffff edited the summary of this revision. (Show Details)Nov 22 2017, 12:23 PM
ffffffff added inline comments.Nov 22 2017, 12:26 PM
binaries/data/mods/public/gui/lobby/lobby.js
26

not sure allowed making this const.

maybe var.

ffffffff edited the summary of this revision. (Show Details)Nov 25 2017, 2:40 PM
ffffffff edited the summary of this revision. (Show Details)Dec 19 2017, 5:45 PM
ffffffff edited the summary of this revision. (Show Details)Dec 20 2017, 3:24 PM
ffffffff added a subscriber: mapkoc.
ffffffff updated this revision to Diff 4827.Dec 20 2017, 3:26 PM
ffffffff edited the summary of this revision. (Show Details)

cleans

Replays in the lobby would be nice, so people know you're still around.

And maybe even nicer would be to have multiplayer replays, in case you want to show something to someone else. I guess the host would control the game speed (maybe cap at 2x speed?), and maybe the camera too? Or maybe having a ping (#3491) would be enough to indicate what to pay attention to. Just some thoughts.

What's not to like here? An unobstructive auto hidable row of buttons that can be disabled if u don't like it.
If u try to disable it and save settings, an error message pops up "some settings values are invalid"
I can apply this patch by itself but not together with D854 or D1154.

Not a fan at all to spam buttons. Wouldn't it be preferable to make that a menu? (and yes we should refactor the menu code, I have a pastebin somewhere for the first step, but it was planned to make menus a c++ GUI object a decade ago)

It is not really spam. It is a decent placement of an auto-hidable menu below the chat input field, or no? With some valueable buttons for multi-players in the lobby, I am feeling very fine with it. Should get a three way dropdown option in the lobby options:

Show More Buttons Bar:

"Disabled"
"Auto-Hide"
"Visible"

That good?

Making a whole new menu would crowd up more, I am feeling and not easy to get to button you want to reach to open.

ffffffff updated this revision to Diff 4896.Dec 22 2017, 11:34 PM

Three dropdown for showing more buttons bar below chat input:

"Disabled"
"Hiding"
"Visible"

.

ffffffff edited the summary of this revision. (Show Details)Dec 22 2017, 11:37 PM
ffffffff edited the summary of this revision. (Show Details)

user1 and me wanted some way to show the Terms of Use. Maybe a button on top of Host game.

Ah this is interesting. I can have a look, maybe crowding buttons there. But could be in more buttons bar f. e..

Also interesting @mapkoc are D790 and D846. Possibly opinion here would be great XD. tx!

We also may get next soon some free button on left side below Leaderboard as User Profile Lookup can be merged into a player search in lobby with a text input field on top over playerlist stating an info when not select with number of Players, Buddies and Games in the lobby. Both possible. Then this is actually a great area to have a Terms & Use button I feel :).

ffffffff edited the summary of this revision. (Show Details)Dec 23 2017, 4:06 PM
ffffffff edited the test plan for this revision. (Show Details)
ffffffff updated this revision to Diff 5035.Jan 2 2018, 4:47 PM

cleans and convertToDialogWindow func

ffffffff updated this revision to Diff 5053.Jan 2 2018, 9:04 PM

setupStyle and pop replay

ffffffff updated this revision to Diff 5298.Jan 14 2018, 11:09 PM

Update for GUI XML attributes in js and last game summary from D854.
Also dialoggable state in summary and replay gui.

ffffffff updated this revision to Diff 5302.Jan 15 2018, 12:14 AM

Update when starting replay from inside lobby pushed gui replaymenu pop first the gui or from open summary dialog from within replaymenu pop guis down to lobby and then switch to page_loading.xml.

ffffffff added inline comments.Jan 15 2018, 4:32 AM
binaries/data/mods/public/gui/replaymenu/replay_actions.js
128

add here [ "page_summary.xml", {...} ]

131

set "dialog": Engine.HasXmppClient(),

143

delete this line and parentheses from if

144

make this Engine.PushGuiPage(...pageSettings);

147

and Engine.SwitchGuiPage(...pageSettings);