Page MenuHomeWildfire Games

Search/filter player in lobby
Needs ReviewPublic

Authored by ffffffff on Nov 25 2017, 10:47 AM.

Details

Reviewers
elexis
Summary

Not sure about this but searching player or just filter player in lobby when lobby is realy crowed is sometimes a good help and generaly you can directly search offline accounts from rankings too.

offline search player account

online search player/filter

please discuss

Test Plan

discuss

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Nov 25 2017, 10:47 AM
ffffffff updated this revision to Diff 4362.Nov 25 2017, 10:51 AM

Probably ok. The approach to combine this text input with the number-of-players label which still isn't committed unfortunately did seem appealing though. But I guess we needed the default-text for input labels in a different color then.

ffffffff edited the summary of this revision. (Show Details)Dec 4 2017, 6:41 PM
ffffffff edited the summary of this revision. (Show Details)Dec 4 2017, 11:46 PM
ffffffff updated this revision to Diff 4547.Dec 4 2017, 11:58 PM
In D1063#42061, @elexis wrote:

Probably ok. The approach to combine this text input with the number-of-players label which still isn't committed unfortunately did seem appealing though. But I guess we needed the default-text for input labels in a different color then.

i tried some code for cinput.cpp but its hard to get achievement for a default text that is written when no caption is applied. its a need an info-text attribute or so that is drawn in the draw() function when caption is empty and maybe cinput not focused. but i couldnt make cinput draw a different text like that from caption :(