Page MenuHomeWildfire Games
Differential D1069

Use default Unicode encoding in source code on Windows
ClosedPublic
Actions

Authored by Itms on Nov 26 2017, 3:05 PM.

Details

Reviewers
None
Commits
rP20561: Use default Unicode encoding in source code on Windows.
Summary

This patch changes MBCS encoding (which was the default with premake4, we kept it) to Unicode encoding (default in premake5).

I'd rather commit this before committing the VS 2015 support than after.

Test Plan

-

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Itms created this revision.Nov 26 2017, 3:05 PM
Vulcan added a subscriber: Vulcan.Nov 26 2017, 6:01 PM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Vulcan added a comment.Nov 26 2017, 6:03 PM
Executing section Default...
Executing section Source...
Executing section JS...
Harbormaster completed remote builds in B3829: Diff 4393.Nov 26 2017, 6:03 PM
Itms added a subscriber: wraitii.Nov 26 2017, 7:59 PM

@wraitii, can you tell me whether that builds on OSX? It works on Windows and Linux but I don't have much time for firing up my VM now...

wraitii added a comment.Nov 26 2017, 8:24 PM

@Itms seems to work on Xcode and gcc

Closed by commit rP20561: Use default Unicode encoding in source code on Windows. (authored by Itms). · Explain WhyNov 29 2017, 9:14 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Nov 29 2017, 9:14 PM

Revision Contents
Changeset List

PathSize
ps/
trunk/
build/
premake/
8 lines
source/
network/
4 lines
ps/
4 lines

Diff 4448

View Options

ps/trunk/build/premake/premake5.lua

Loading...
View Options

ps/trunk/source/network/StunClient.cpp

Loading...
View Options

ps/trunk/source/ps/UniDoubler.h

Loading...
Wildfire Games · Phabricator