Page MenuHomeWildfire Games

Sort mods with arrow icons and string changes
AbandonedPublic

Authored by elexis on Nov 29 2017, 12:02 AM.

Details

Reviewers
None
Summary

Not sure why there should be parentheses around the folder column. "X" isn't really visually attractive for a button label if the ones above and below are labeled with words.
Might not fit with all languages however.

Test Plan

long strings test.

Event Timeline

elexis created this revision.Nov 29 2017, 12:02 AM
Imarok added a subscriber: Imarok.Nov 29 2017, 12:15 AM

Looks good, but Disable doesn't fit into the button on min res. You should give the button an apropriate constant width.

I expect that we have that string in some other GUI context. Then we can see if english is the longest translation of the string (which it likely isnt)

elexis planned changes to this revision.Nov 29 2017, 12:25 AM
Vulcan added a subscriber: Vulcan.Nov 29 2017, 12:35 AM

Build failure - The Moirai have given mortals hearts that can endure.

Executing section Default...
Executing section Source...
Executing section JS...
leper added inline comments.
binaries/data/mods/mod/gui/modmod/modmod.js
58

Why?

elexis added inline comments.Nov 29 2017, 2:17 AM
binaries/data/mods/mod/gui/modmod/modmod.js
58

More common

elexis added a subscriber: Stan.Dec 1 2017, 1:54 PM

These labeled buttons are just ugly.
We should consult the expert on the topic @Stan to use arrow icons instead of text.
The disable button should be moved to the lower panel to show the human-readable element in any language and make it consistent with the enable button positioning.

binaries/data/mods/mod/gui/modmod/modmod.js
58

Don't really care though.

Stan added a comment.Dec 1 2017, 2:43 PM

If I understand what you guys are talking about which is hard without screens of the issue and considering I mostly use command line options, the idea would be to replace "Enable" and "X" buttons by arrows ?

Imarok added a comment.Dec 1 2017, 2:57 PM

refs #4186

We could also use doubleclick on the item to enable/disable it.

elexis added a comment.Dec 1 2017, 3:40 PM
In D1079#43290, @Stan wrote:

If I understand what you guys are talking about which is hard without screens of the issue and considering I mostly use command line options, the idea would be to replace "Enable" and "X" buttons by arrows ?

No, IMO enable should become an "enable" button just like the "disable" button.
But the "Up" and "Down" buttons should become arrows. I'll upload a patch with the existing arrow icons, then we'll see if they fit.

Stan added a comment.Dec 1 2017, 3:58 PM

Just checked. Yes Those buttons should be replaced by arrows / Icons. The X too, if applicable.
If not I'd suggest to merge the two lists, and make the enable button a enable/disable buttons, and grey out disabled mods.

elexis added a comment.Dec 1 2017, 4:06 PM
In D1079#43323, @Stan wrote:

The X too, if applicable.

As long as the Disable button and Enable button have the same characteristics.
Again I think it is easier to understand if the button is on a separate row just like the other button is.
But if you know an Enable and Disable icon for mods that is as intuitive as arrows for Up and Down, might be okay. (Possibly awkward to not have save abort and close as icons too).

grey out disabled mods.

IMO mods that aren't compatible to the engine version or have a invalid mod.json should optionally be listed as grayed out instead of always hiding them (like the replay menu).
(Also one needs to be able to sort mods by launch order which won't work when merging the two lists.)

elexis retitled this revision from Mod selection string changes to Sort mods with arrow icons and string changes.Dec 2 2017, 1:05 PM
elexis abandoned this revision.Dec 12 2017, 8:40 PM