Page MenuHomeWildfire Games

Deprecate mod types
ClosedPublic

Authored by elexis on Nov 29 2017, 11:33 AM.

Details

Summary

In rP20552#inline-1159 leper wrote:

Types are mostly something rada added. I still consider adding that a mistake.

Someone might (likely unlikely) come up with a use case for type properties.
But then they should be well defined and not as arbitrary as the description field.
I wouldn't disagree to delete them, here the diff.
It could be reverted easily when changing our mind.
The deprecation doesn't break mod parsing.

Test Plan

Read well.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Nov 29 2017, 11:33 AM
Vulcan added a subscriber: Vulcan.Nov 29 2017, 11:36 AM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Executing section Default...
Executing section Source...
Executing section JS...

Agreed on the change for now, particularly given that we have no validation.

leper requested changes to this revision.Nov 29 2017, 10:18 PM

Does this actually differ from D1081?

Same comment applies.

This revision now requires changes to proceed.Nov 29 2017, 10:18 PM
elexis updated this revision to Diff 4449.Nov 29 2017, 10:51 PM

Only deprecate the type in this diff.

elexis retitled this revision from Deprecate type and non-numeric version string parsing from the mod selection page to Deprecate mod types.Nov 29 2017, 10:52 PM
Executing section Default...
Executing section Source...
Executing section JS...

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
wraitii accepted this revision.Dec 3 2017, 6:26 PM
This revision was automatically updated to reflect the committed changes.