Page MenuHomeWildfire Games

Fix name colors in gamedescription
ClosedPublic

Authored by ffffffff on Nov 30 2017, 1:40 PM.

Details

Summary

Before in gamedescription the color was calculated by name including rate but normaly in lobby it is calculate by only name so use splitnamerate function and only use name for calculate color

Test Plan

look lobby gamedescription players on a game f.e. check colors from names with rates and compare to them in lobby player list without and with patch

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ffffffff created this revision.Nov 30 2017, 1:40 PM
ffffffff edited the test plan for this revision. (Show Details)Nov 30 2017, 1:43 PM
Imarok accepted this revision.Dec 1 2017, 3:16 PM
Imarok added a subscriber: Imarok.

Good catch

This revision is now accepted and ready to land.Dec 1 2017, 3:16 PM
elexis added a comment.Dec 1 2017, 3:31 PM

(That typeof getPlayerColor == 'function' isn' too clean. We might have cought this inconsistency in lobby.js if we had passed the colorization function from the caller.)
(Some day the ratings might should not be part of the nick anymore.)

This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Dec 5 2017, 9:29 PM