Delete unused unintentional StartingCamera in maps
AcceptedPublic
Actions

Authored by elexis on Dec 1 2017, 11:31 PM.

Details

Reviewers

wraitii

Trac Tickets

#4839

Summary

The StartingCamera per player is currently overwritten by the GameView focusing on the first entity, preferably the civic center.
If the StartingCamera feature should be used, these maps should still focus the civic center or a player entity by default.

This doesn't remove the <Camera> element which is likely used for observers. Observermode should also use the map center unless there is a really good reason.
rmgen/ is also a special case not addressed here.

Test Plan

Notice that the numbers are unused. Notice that we actually do want to focus on player entities on all maps.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 3910
Build 6825: Vulcan Build (Windows)	Jenkins
Build 6824: Vulcan Build	Jenkins
Build 6823: arc lint + arc unit

Event Timeline

elexis created this revision.Dec 1 2017, 11:31 PM

Harbormaster completed remote builds in B3910: Diff 4483.Dec 1 2017, 11:31 PM

Build failure - The Moirai have given mortals hearts that can endure.

Harbormaster failed remote builds in B3910: Diff 4483!Dec 1 2017, 11:32 PM

Executing section Default...
Executing section Source...
Executing section JS...

wraitii accepted this revision.Dec 3 2017, 6:25 PM

This revision is now accepted and ready to land.Dec 3 2017, 6:25 PM

I believe we should also teach Atlas to not save a starting position if we don't want it (possibly before committing this), otherwise that value is just going to be written back again with the next map edit.

elexis mentioned this in rP22387: Improve starting position camera for Oceanside (2).Jun 25 2019, 11:58 PM

elexis mentioned this in rP23279: Clean Skirmish maps of default and invalid gamesetting values..Dec 24 2019, 5:39 AM

I have a question about this. Did you check in Atlas? Because that restores the camera properly for me... It's useful to take screenshots exactly at the same spot. For instance if you'd like to compare A23 and A24...

In D1098#43917, @elexis wrote:

I believe we should also teach Atlas to not save a starting position if we don't want it (possibly before committing this), otherwise that value is just going to be written back again with the next map edit.

Which position we should use for the camera if it wasn't set by a map?