Differential D1102
Add a terrain-shadows option Authored by wraitii on Dec 3 2017, 1:31 PM.
Details
Our terrain is mostly flat, and our sun is mostly vertical, so on most maps terrain doesn't get to have shadows. But we still render it again just in case if shadows are enabled. This adds a setting to skip that. (this is an old branch of mine that I just rediscovered) Mostly decide whether we want this or not. On my computer it seems to make no difference at all.
Diff Detail
Event TimelineComment Actions The use case is optimizing performance? I actually didn't see any terrain shadow, can you show a screenshot? For instance on Acropolis Bay the starting mountain doesn't seem to show any shadow. Comment Actions
It is (well hopes to be anyways).
As said in the test plan, on my computer this makes no difference, which is why I'm wondering whether it's useful or not. If somebody with a terrible computer can give some numbers.
It's testable on alpine mountains, for example. Acropolis Bay appears to have a very vertical sun that shows no shadows anywhere. Comment Actions Okay I saw it on Alpine Mountains. Strange that its not seen on the other maps with hills (Acropolis bay still has significant shadows for trees). I still think its neat to allow configuration of things. How about making that a user.cfg only option, add a comment that this is doesn't really influence the performance (misses default.cfg entry to begin with)?
Comment Actions If we go with the manual config only way, I still wouldn't disagree to have the unused JSInterface part in there. Patch looks complete but I wouldn't bet my balls on that. Comment Actions Successful build - Chance fights ever on the side of the prudent. Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files... Comment Actions The problem is other objects requires much more time to render their shadows. Also the vertex buffer of the terrain is pretty simple and not bad ordered. So I think it's not easy to get really improvements, even on slow PCs. But it could be a hidden checkbox or a JS function as @elexis said. | ||||||||||||||||||||||