Unify FileExists and DataFileExists
ClosedPublic
Actions

Authored by elexis on Dec 4 2017, 2:26 AM.

Details

Reviewers: None
Commits: rP20588: Expose the same FileExists to JS GUI, simulation and rmgen.
Trac Tickets: #4868

Summary

See ticket. The idea is to have the same function name, same function arguments and same return value in gui, simulation, rmgen, AI,
avoid modified copy&pasted code in C++ and move all VFS code to the VFS files.

Test Plan

Make sure it compiles.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Dec 4 2017, 2:26 AM

Executing section Default...
Executing section Source...
Executing section JS...

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

Harbormaster completed remote builds in B3940: Diff 4520.Dec 4 2017, 3:15 AM

Closed by commit rP20588: Expose the same FileExists to JS GUI, simulation and rmgen. (authored by elexis). · Explain WhyDec 5 2017, 1:22 AM

This revision was automatically updated to reflect the committed changes.

Owners added a subscriber: Restricted Owners Package.Dec 5 2017, 1:22 AM