Use PlayerID rather than PlayerEnt in Barter, like most components.
Details
Details
Check that everything's been updated.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
Comment Actions
Agree.
Correctness: HasMarket and GetPrices actually need a playerID, so seems nicer to just pass that as the functions calling that have access to it.
Completeness: Searched for all function names, all calls are addressed.
Thanks for the patch and splitting it D1050, made it much easier to review!
(Also you might have noticed that I prefer playerID over playerId).
binaries/data/mods/public/simulation/components/tests/test_Barter.js | ||
---|---|---|
21 ↗ | (On Diff #4590) | lets make this playerEnt |
111 ↗ | (On Diff #4590) | and these playerID |