Add timeOfDayToString and chatTimestampToString functions.
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Agree they're nice.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 4007 Build 7027: Vulcan Build Jenkins Build 7026: arc lint + arc unit
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
binaries/data/mods/public/gui/common/l10n.js | ||
---|---|---|
6 ↗ | (On Diff #4593) | I should've made a note here, it's the seconds. The realtime overlay currently shows them and all the other places don't show them. So either we could have two functions, one showing seconds and one not showing them, or we could decide on one format. I'd actually prefer to not show the seconds because I think it's unnecessary, and actually in the US-english version I don't include them (I use "H:mm a" which gives times like "8:44 AM"). So let me remove the :ss. |
binaries/data/mods/public/gui/common/l10n.js | ||
---|---|---|
6 ↗ | (On Diff #4593) | "h:mm a" actually. |
Hm. The seconds in the overlay enabled one to count how many real seconds passed in one game second. In the chat they wouldn't hurt too much though certainly not necessary.
Perhaps we want two formats and pass it as a boolean if we want to show the seconds?
binaries/data/mods/public/gui/common/l10n.js | ||
---|---|---|
1 ↗ | (On Diff #4593) | timeToString? |
For measuring lag? Because we show (2x) when at different speeds. The US will have AM/PM there too, will be crowded.
Perhaps we want two formats and pass it as a boolean if we want to show the seconds?
Doesn't hurt. So I'll add it to the realtime overlay for now.
binaries/data/mods/public/gui/common/l10n.js | ||
---|---|---|
1 ↗ | (On Diff #4593) | We don't want people using this function when they should use durationToString, so I think it's better to emphasize that it's a time of day. |
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...