Adds test in ProductionQueue for the {civ} tech replacement from rP20551
ClosedPublic
Actions

Authored by mimo on Dec 7 2017, 7:49 PM.

Details

Reviewers

elexis

Commits

rP20604: Adds test in ProductionQueue for the {civ} tech replacement from rP20551

Summary

Complete the tests in ProductionQueue introduced in rP20603 to also cover the tech replacement from rP20551

Test Plan

Check that the tests run

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mimo created this revision.Dec 7 2017, 7:49 PM

Test succeeds.
A testcase where one can train templates of two different civs might catch some edge case if one wants to add more coverage.

binaries/data/mods/public/simulation/components/tests/test_ProductionQueue.js
16 ↗	(On Diff #4633)	classic
21 ↗	(On Diff #4633)	(I meant one template per line, so that all start with `units/` at the same location)
78 ↗	(On Diff #4633)	I guess one of the reviewers could have been more skeptical
118 ↗	(On Diff #4633)	foo( bar, [x1, x2]); or foo( bar [ x1, x2 ]); or not
131 ↗	(On Diff #4633)	(Someone could have used arrays or Sets when introducing the thing)

This revision is now accepted and ready to land.Dec 7 2017, 8:03 PM

Build failure - The Moirai have given mortals hearts that can endure.

Harbormaster failed remote builds in B3998: Diff 4633!Dec 7 2017, 8:27 PM

Executing section Default...
Executing section Source...
Executing section JS...

Closed by commit rP20604: Adds test in ProductionQueue for the {civ} tech replacement from rP20551 (authored by mimo). · Explain WhyDec 7 2017, 10:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

tests/

test_ProductionQueue.js

77 lines

Diff 4638

View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_ProductionQueue.js

Adds test in ProductionQueue for the {civ} tech replacement from rP20551ClosedPublicActions