Done by drawing the line below the list. Thus the list gets 1px bigger than defined in xml.
Details
- Reviewers
gentz vladislavbelov - Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Look at some list/olist and scroll
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 4761 Build 8259: Vulcan Build (Windows) Jenkins Build 8258: Vulcan Build Jenkins Build 8257: arc lint + arc unit
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
Other places should be adjusted the same way, whatever's decided.
My solution was to change the z_level. I don't know what's best.
https://code.wildfiregames.com/D1023#40247
Given that my order change in C++ didn't work out it must have been a Z issue, so that would be a lesser workaround than the +1 px.
Not sure how we would specify a clipping area for the text. @vladislavbelov got an idea?
I believe the Z-index fix is the correct one, because we might want to render a transparent sprite in the middle of the list above the text (hypothetically) which we can't clip.
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
There are other places with scroll bars and text over the bottom/top, might want to fix all of those too.
(I think the dropdown uses a border so instead probably need to make a "black box" sprite.)
Any place where there's a scroll bar then it's probably a problem. E.g. in the replay menu with the map dropdown.
Also in the match setup select map dropdown and map information. There were problems in the game lobby, I don't know if those are fixed or not.
Basically, in all of the box sprites you'll probably want to add z_level to the gold-separator and white-separator images. And also make a black box sprite to use in the dropdowns.
binaries/data/mods/mod/gui/common/modern/sprites.xml | ||
---|---|---|
183–190 | This sprite is used for the selection box, and here we can see that it's covered by the new black sprite: It seems to be fixed by again using z_level = "11". I think this sprite is used in some scroll boxes too but maybe it's hard to tell if the white border is the same color as the white text. I didn't check where all the box sprites were used or if they're all used, but it seems like whenever we have borders on boxes we'll never want text to be on top. So I think we should make the z_level adjustment in all of them. | |
482 | unnecessary? | |
486 | I think we want another at the top as well, since words can cover the border: |
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (309 tests).....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (309 tests).....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...