TechnologyManager researchStarted is an Object where the properties are technologyNames and values either true or undefined.
So it should be a Set or an Array.
Details
Details
Research a tech, let the AI do it too. Notice we serialize Sets in many places, so serialization shoudn't be an issue.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
Comment Actions
Executing section Default... Executing section Source... Executing section JS... binaries/data/mods/public/simulation/components/TechnologyManager.js | 69| » » » ||·(tech.top·&&·(this.IsTechnologyResearched(tech.top)·||·this.IsTechnologyResearched(tech.bottom)))) | | [NORMAL] JSHintBear: | | Misleading line break before '||'; readers may interpret this as an expression boundary. binaries/data/mods/public/simulation/components/TechnologyManager.js | 235| » » » for·(var·component·in·modifiedComponents) | | [NORMAL] JSHintBear: | | 'component' is already defined. binaries/data/mods/public/simulation/components/TechnologyManager.js | 241| » » var·cmpTemplateManager·=·Engine.QueryInterface(SYSTEM_ENTITY,·IID_TemplateManager); | | [NORMAL] JSHintBear: | | 'cmpTemplateManager' is already defined. binaries/data/mods/public/simulation/components/TechnologyManager.js | 242| » » var·template·=·cmpTemplateManager.GetCurrentTemplateName(msg.entity); | | [NORMAL] JSHintBear: | | 'template' is already defined. binaries/data/mods/public/simulation/components/TechnologyManager.js | 247| » » » var·cmpIdentity·=·Engine.QueryInterface(msg.entity,·IID_Identity); | | [NORMAL] JSHintBear: | | 'cmpIdentity' is already defined. binaries/data/mods/public/simulation/components/TechnologyManager.js | 250| » » » » var·classes·=·cmpIdentity.GetClassesList(); | | [NORMAL] JSHintBear: | | 'classes' is already defined. binaries/data/mods/public/simulation/components/TechnologyManager.js | 308| » » » var·template·=·this.GetTechnologyTemplate(i); | | [NORMAL] JSHintBear: | | 'template' is already defined.