Page MenuHomeWildfire Games

Fix a translation comment of infinity symbol in the summary screen
ClosedPublic

Authored by temple on Dec 9 2017, 6:11 PM.

Details

Summary

The multiline translation comment did not work, see public-gui-other.pot:

#: gui/summary/summary.js:113
msgid "∞"
msgstr ""

(Some discussion at D1116.)

Test Plan

Alternative is to fix multilinecomment in source/tools/i18n/extractors/.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

temple created this revision.Dec 9 2017, 6:11 PM
Owners added a subscriber: Restricted Owners Package.Dec 9 2017, 6:11 PM
elexis accepted this revision.Dec 9 2017, 6:25 PM
elexis added a subscriber: elexis.

It looks like a failed JSDoc attempt.
(So at least this by itself shouldn't be taken as a reason to change the jslexer.)
According to the revision history that was me in rP20043, yay.

I do recollect this:

session/selection_details.js:		let resources = entState.resourceSupply.isInfinite ? translate("∞") :  // Infinity symbol

We could use the same symbol in both cases, but then transifex people can't pick a different string for each call.
(I never liked showing infinite kill death ratio when killing one scout without anyone dying.)

Also I wouldn't be surprised if there are people asking on transifex about this string.

So unless you want to go down the path of removing this symbol here, fixing the comment is good.

This revision is now accepted and ready to land.Dec 9 2017, 6:25 PM
Vulcan added a subscriber: Vulcan.Dec 9 2017, 7:00 PM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
This revision was automatically updated to reflect the committed changes.
elexis retitled this revision from Fix a translation comment to Fix a translation comment of infinity symbol in the summary screen.Dec 10 2017, 4:38 AM