Seems just a tiny bit cleaner.
Details
Details
- Reviewers
- None
- Commits
- rP20657: Use Array.from intead of the spread operator (that's more readable and more…
It's functional if the AI can still order its units. I should test for performance before committing. Perhaps its much faster (like we noticed in some other commit).
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 4040 Build 7091: Vulcan Build (Windows) Jenkins Build 7090: Vulcan Build Jenkins Build 7089: arc lint + arc unit
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
Comment Actions
Executing section Default... Executing section Source... Executing section JS... binaries/data/mods/public/simulation/ai/common-api/entitycollection.js | 41| » » this._filters.push(eval(f)); | | [NORMAL] JSHintBear: | | eval can be harmful.
Comment Actions
Agreed, more readable and faster according to my tests. I'll commit it with some additions.