Page MenuHomeWildfire Games

Move from CCmpSelectable::UpdateTexturedLineOverlay to simulation2/helpers/Render.cpp and graphics/Overlay.cpp
ClosedPublic

Authored by elexis on Dec 10 2017, 12:17 AM.

Details

Summary

This is a preparation of D555 to avoid duplication when these moved functions will be reused.

Test Plan

Compile, start a game, select women and CC. Read the code and notice that it's the ideal location.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Dec 10 2017, 12:17 AM
Vulcan added a subscriber: Vulcan.Dec 10 2017, 12:34 AM
Executing section Default...
Executing section Source...
Executing section JS...

What I got on IRC:

17:36 < elexis> OverlayRenderer.cpp?
17:36 < echotangoecho> sounds that's where it should be

(Overlay.cpp is better because it doesn't need a proxy in Renderer.cpp and the function could even become part of the obejct it changes)

21:55 < Vladislav> elexis: then I agree, if it's just the refactoring.

source/simulation2/helpers/Render.cpp
630 ↗(On Diff #4682)

size_t as mentioned by Vladislav in D555

This revision was automatically updated to reflect the committed changes.
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Dec 10 2017, 1:20 AM

Build failure - The Moirai have given mortals hearts that can endure.