Differential D1141

Hide quit button in the mod selection page started from the public mod
ClosedPublic
Actions

Authored by elexis on Dec 10 2017, 5:39 PM.

Details

Reviewers

Grugnas

Commits

rP20645: Hide the cancel button in the modmod of the mod mod and the quit button when…

Trac Tickets

#4890

Summary

As Grugnas mentioned, the Quit button is a bit counterintuitive in the mod selection page when that is started through the public mod.
Mostly because the gui pages of the public mod otherwise have no immediate quit buttons either (and why would they have to?).

Should we disable the cancel

Test Plan

Start the game with mods and without mods, both times entering the mod selection menu.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Dec 10 2017, 5:39 PM

Executing section Default...
Executing section Source...
Executing section JS...

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

Harbormaster completed remote builds in B4075: Diff 4705.Dec 10 2017, 10:01 PM

Whenever the game is started without any mod enabled, the Quit button replaces the Cancel button and that's really intuitive now.

This revision is now accepted and ready to land.Dec 12 2017, 4:47 PM

elexis updated the Trac tickets for this revision.Dec 12 2017, 5:04 PM

Closed by commit rP20645: Hide the cancel button in the modmod of the mod mod and the quit button when… (authored by elexis). · Explain WhyDec 12 2017, 5:07 PM

This revision was automatically updated to reflect the committed changes.