Hotkey for next/previous tab in summary window
AbandonedPublic
Actions

Authored by ffffffff on Dec 11 2017, 11:07 PM.

Details

Reviewers

Summary

This depends on D810

When in summary window (especialy in-game) its much comfortable to switch tabs with an easy tab/shift + tab switch and as we dont have an text input focus here at moment which would interfere with tab hotkey mapping, it would nice to have here tab and tab+shift as tab switch hotkeys when inside summary window.

so adding tab/shift+tab hotkey for summay window panel switch. pls discuss

Test Plan

discuss

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

ffffffff created this revision.Dec 11 2017, 11:07 PM

elexis resigned from this revision.Dec 12 2017, 8:37 PM

ffffffff edited the summary of this revision. (Show Details)Dec 21 2017, 3:42 PM

ffffffff added subscribers: causative, temple.

elexis added inline comments.Dec 21 2017, 5:01 PM

binaries/data/config/default.cfg
335	toggle

workx great tx.

ffffffff added a subscriber: mapkoc.Dec 23 2017, 1:07 AM

summary.toggle can be nice naming, but having a class for just one value is meh

binaries/data/config/default.cfg
338–339	we already have hotkeys for this and I am opposed to defining two hotkeys to the same feature. Also who says there won't coma a chat in the summary screen, so tab won't work there.

ffffffff added inline comments.Dec 25 2017, 12:27 AM

binaries/data/config/default.cfg
338–339	yea chat comes to summary can be fixed deleting hotkeys. Where we don't have chat input we could take this hotkeys (is that everywbere, where panels are?) its best hotkey for switching panels : )

ffffffff added inline comments.Dec 25 2017, 12:43 AM

binaries/data/config/default.cfg
338–339	ok not true. options got text input field if they got focused tab dont work : ( not sure for good solution feeling ok for having panel guis boxes tab and shift+tab as switch for panels and alt+s and alt+w as backup hotkey if text input is focused.

bb added inline comments.Dec 25 2017, 1:01 AM

binaries/data/config/default.cfg
338–339	(there is always the option to change the user.cfg if one wants to use the tabs hotkeys, don't know if it is possible to assign two hotkeys to the same thing from there)

ffffffff added inline comments.Dec 25 2017, 1:06 AM