Delenda Est has a fourth phase that is autoresearched after gaining a wonder.
In order to supress the notification of the village phase, D354 / rP19445 supressed all autoresearched technologies.
So the check must be replaced with something more customizable.
This patch lets default.cfg specify supression of specific phases.
Another use case of this customization is implemented here: allowing observers to see non-supressed notifications of researched technologies by all players.
This could be extended to optionally show specific technologies like Will To Fight or the wonder population technologies of allies to players.
Details
Details
- Reviewers
- None
Patch unfinished (iirc needs something for the unused autoresearched tech pairs), so ignore it. Three unrelated hunks for fun.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 4130 Build 7266: Vulcan Build (Windows) Jenkins Build 7265: Vulcan Build Jenkins Build 7264: arc lint + arc unit
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
Comment Actions
Executing section Default... Executing section Source... Executing section JS... binaries/data/mods/public/simulation/components/TechnologyManager.js | 69| » » » ||·(tech.top·&&·(this.IsTechnologyResearched(tech.top)·||·this.IsTechnologyResearched(tech.bottom)))) | | [NORMAL] JSHintBear: | | Misleading line break before '||'; readers may interpret this as an expression boundary. binaries/data/mods/public/simulation/components/TechnologyManager.js | 226| » » » for·(var·component·in·modifiedComponents) | | [NORMAL] JSHintBear: | | 'component' is already defined. binaries/data/mods/public/simulation/components/TechnologyManager.js | 232| » » var·cmpTemplateManager·=·Engine.QueryInterface(SYSTEM_ENTITY,·IID_TemplateManager); | | [NORMAL] JSHintBear: | | 'cmpTemplateManager' is already defined. binaries/data/mods/public/simulation/components/TechnologyManager.js | 233| » » var·template·=·cmpTemplateManager.GetCurrentTemplateName(msg.entity); | | [NORMAL] JSHintBear: | | 'template' is already defined. binaries/data/mods/public/simulation/components/TechnologyManager.js | 238| » » » var·cmpIdentity·=·Engine.QueryInterface(msg.entity,·IID_Identity); | | [NORMAL] JSHintBear: | | 'cmpIdentity' is already defined. binaries/data/mods/public/simulation/components/TechnologyManager.js | 241| » » » » var·classes·=·cmpIdentity.GetClassesList(); | | [NORMAL] JSHintBear: | | 'classes' is already defined. binaries/data/mods/public/simulation/components/TechnologyManager.js | 453| » return·this.researchQueued.get(tech) | | [NORMAL] JSHintBear: | | Missing semicolon.