Page MenuHomeWildfire Games
Differential D1178

Initialize AIManager RNG Seed in Simulation2, not JS
ClosedPublic
Actions

Authored by elexis on Dec 26 2017, 10:41 PM.

Details

Reviewers
mimo
Commits
rP20700: Initialize the AIManager AISeed immediately in C++ rather than too late and in…
Trac Tickets
#4907
Summary

As described in #4907 and discovered by mimo in D1159, the AISeed from rP15973 is initialized a bit too late in InitGame of simulation/helpers/InitGame.js.
So the Config function in config.js of the bot does not use the intended RNG seed.

To remove the possibility that a statement is inserted in some JS code prior to the Seed initialization, the Seed can be initialized immediately in C++ once the Simulation2 is aware of the setting.
It can be done the same way as it is done for the Seed.

Test Plan

Notice the code symmetry. One can add debug_printf and warn to these functions to see the execution order.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Dec 26 2017, 10:41 PM
Vulcan added a subscriber: Vulcan.Dec 27 2017, 12:21 AM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Vulcan added a comment.Dec 27 2017, 12:23 AM
Executing section Default...
Executing section Source...
Executing section JS...
Harbormaster completed remote builds in B4190: Diff 4964.Dec 27 2017, 12:23 AM
mimo accepted this revision.Dec 27 2017, 4:30 PM

Patch is good, and works as expected

This revision is now accepted and ready to land.Dec 27 2017, 4:30 PM
elexis added a comment.Dec 27 2017, 4:30 PM

Thanks for the review!

Closed by commit rP20700: Initialize the AIManager AISeed immediately in C++ rather than too late and in… (authored by elexis). · Explain WhyDec 27 2017, 5:51 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Dec 27 2017, 5:51 PM
elexis mentioned this in D1187: Fix AISeed warning in Atlas.Dec 30 2017, 1:59 PM
elexis mentioned this in rP20726: Let Atlas provide a default AI seed..Dec 30 2017, 3:02 PM

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
helpers/
2 lines
source/
simulation2/
33 lines
components/
1 line

Diff 4971

View Options

ps/trunk/binaries/data/mods/public/simulation/helpers/InitGame.js

Loading...
View Options

ps/trunk/source/simulation2/Simulation2.cpp

Loading...
View Options

ps/trunk/source/simulation2/components/ICmpAIManager.cpp

Loading...
Wildfire Games · Phabricator