Page MenuHomeWildfire Games

Make XMPP-bots work with newer SleekXMPP versions
AbandonedPublic

Authored by Dunedan on Dec 28 2017, 2:48 PM.

Details

Reviewers
Itms
Summary

Even though the README claims that XpartaMuPP and EcheLOn work with SleekXMPP 1.3.1 I noticed they don't work with SleekXMPP > 1.1.5. This patch makes them compatible with SleekXMPP >= 1.1.7 (1.1.6 is broken for other reasons).

P.S.: In case you want to look into the changes between the SleekXMPP versions: Apparently they messed up their git tags, so the tagged versions will show no differences. The Python packages on Pypi do however.

Test Plan

Take the code from SVN, run the bots using SleekXMPP > 1.1.6 and notice they don't work (e.g. new games won't show up for players).
Then apply the patch and notice that everything works again.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

Dunedan created this revision.Dec 28 2017, 2:48 PM
Vulcan added a subscriber: Vulcan.Dec 28 2017, 3:47 PM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Dunedan updated this revision to Diff 5322.Jan 15 2018, 7:23 PM

For whatever reason the changes for EcheLOn were missing. This update to the patch adds them

Itms added a reviewer: Itms.Feb 12 2018, 7:25 PM
Itms added a subscriber: Itms.

I am waiting for implodedok to perform an upgrade of the machine, I will commit when I perform the upgrade.

Itms abandoned this revision.Apr 14 2018, 2:48 PM

I merged this in D206. ?

Imarok added a subscriber: Imarok.Apr 14 2018, 9:58 PM
In D1182#59112, @Itms wrote:

I merged this in D206. ?

Closing would have been better ;)
(But thanks for working on it ?)