Allow different ingame name with real username revelation
Needs ReviewPublic
Actions

Authored by ffffffff on Jan 1 2018, 12:41 PM.

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

We may should give the opportunity to the players to give a little more space for people wanting have different name, when going into a game, when in lobby. So they dont need to connect by ip or stuff with totaly different name. So we can control the naming a little.

We already have the option for making a multiplayer name in options. It is applied for host game outside lobby and join game by ip also outside lobby.

How about applying this option for in game name, when connecting from lobby, with real username in parentheses for revelation? Then we know who it is and player can change name without problem.

So when multiplayer name is setted different to username in lobby and player connect to a game or host a game, this patch makes a name like:

Multiplayername (Username) (Rating)

f.e.: HiHello (fpre) (1697) <- this implementation
or: HiHello (fpre, 1697)
or different

Maybe we should go for: smurfname* (1697) and having different color then white maybe cyan or something.
Then we need a playerlist with real name accound revelation to the smurf name.

discuss

Test Plan

Apply patch. Make a name in general options in multiplayer name different from lobby account name. Host a game and go into. Or join a game and look name

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

ffffffff created this revision.Jan 1 2018, 12:41 PM

I tried it out and it works as advertised. While I like the idea in general I find the two-names-per-chat-message a bit too much. What about showing the lobby-username only in the summary screen and using the multiplayer name for the chat messages, no matter how the multiplayer game was set up?

Just as an additional note: For me that's only half of the enhancment, the other half would be to show the configured multiplayer name in the lobby as well. That'd be relatively easy to achieve, once the XMPP bots properly handle the distinction between JIDs and MUC nicks (they currently don't, but I'm working on that already). Once that's done it'd be as simple as:

replace the nick set for the MUC room from the currently used local part of the JID (= lobby username), to the multiplayer nick
adjust the code so the JID is shown somewhere in the lobby. For the lobby I'd prefer in the user profile view instead of as part of every chat message.

That's probably something for another revision later on.

ffffffff edited the summary of this revision. (Show Details)Jan 15 2018, 12:19 AM

ffffffff edited the summary of this revision. (Show Details)

Correct multiplayer name for gamesetup mp and join by ip.

I think we should solve this issue in a clean way, by using three "datafields": nick, "realname" and rating.
This diff also is incompatible to D897.

IMO there should only be one nick per client.

Yea true this would work only if we make D897 with secure option switch for game. So you can still change name (or add name) to ur account and connect to unsecure games. Im with u clean way as u said should solve this. This is more a quick solution if want to give that a go. This could be then shown a given nickname in game and in a playerlist this data fields like you said to resolve this. Actually i just wanted to start making a playerlist for bbs new gamesetup tabs D1027 (and then for ingame).

In D1188#49688, @elexis wrote:

IMO there should only be one nick per client.

Uh, yes totally forgot to write that: I don't really see the usecase of a second nick.

ffffffff edited the summary of this revision. (Show Details)Jan 18 2018, 5:33 AM

In D1188#49713, @Imarok wrote:

In D1188#49688, @elexis wrote:

IMO there should only be one nick per client.

Uh, yes totally forgot to write that: I don't really see the usecase of a second nick.