Page MenuHomeWildfire Games

Cleanup summary selection from D810 / rP20644
Needs ReviewPublic

Authored by bb on Jan 7 2018, 2:59 AM.

Details

Reviewers
elexis
Summary

Draft of improvements on some odd things mentioned in rP20644.

Test Plan

Make sure front doesn't fall

Event Timeline

elexis created this revision.Jan 7 2018, 2:59 AM
elexis edited the summary of this revision. (Show Details)Jan 7 2018, 3:02 AM
Vulcan added a subscriber: Vulcan.Jan 7 2018, 6:04 AM
Executing section Default...
Executing section Source...
Executing section JS...
Vulcan added a comment.Jan 7 2018, 6:22 AM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (308 tests)....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
bb commandeered this revision.Jan 30 2018, 4:58 PM
bb updated this revision to Diff 5591.
bb added a reviewer: elexis.
bb edited the test plan for this revision. (Show Details)

as the old test plan

Owners added a subscriber: Restricted Owners Package.Jan 30 2018, 4:59 PM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (309 tests).....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (309 tests).....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Executing section Default...
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 2.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/summary/summary.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/summary/summary.js
| 510| 510| 	Engine.GetGUIObjectByName("summaryText").caption =
| 511| 511| 		g_GameData.gui.isInGame ?
| 512| 512| 			translate("Current Scores") :
| 513|    |-		g_GameData.gui.isReplay ?
|    | 513|+			g_GameData.gui.isReplay ?
| 514| 514| 			translate("Scores at the end of the game.") :
| 515| 515| 		g_GameData.gui.disconnected ?
| 516| 516| 			translate("You have been disconnected.") :
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 3.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/summary/summary.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/summary/summary.js
| 511| 511| 		g_GameData.gui.isInGame ?
| 512| 512| 			translate("Current Scores") :
| 513| 513| 		g_GameData.gui.isReplay ?
| 514|    |-			translate("Scores at the end of the game.") :
|    | 514|+				translate("Scores at the end of the game.") :
| 515| 515| 		g_GameData.gui.disconnected ?
| 516| 516| 			translate("You have been disconnected.") :
| 517| 517| 		!assignedState ?
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 2.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/summary/summary.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/summary/summary.js
| 512| 512| 			translate("Current Scores") :
| 513| 513| 		g_GameData.gui.isReplay ?
| 514| 514| 			translate("Scores at the end of the game.") :
| 515|    |-		g_GameData.gui.disconnected ?
|    | 515|+				g_GameData.gui.disconnected ?
| 516| 516| 			translate("You have been disconnected.") :
| 517| 517| 		!assignedState ?
| 518| 518| 			translate("You have left the game.") :
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 3.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/summary/summary.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/summary/summary.js
| 513| 513| 		g_GameData.gui.isReplay ?
| 514| 514| 			translate("Scores at the end of the game.") :
| 515| 515| 		g_GameData.gui.disconnected ?
| 516|    |-			translate("You have been disconnected.") :
|    | 516|+					translate("You have been disconnected.") :
| 517| 517| 		!assignedState ?
| 518| 518| 			translate("You have left the game.") :
| 519| 519| 		assignedState.state == "won" ?
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 2.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/summary/summary.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/summary/summary.js
| 514| 514| 			translate("Scores at the end of the game.") :
| 515| 515| 		g_GameData.gui.disconnected ?
| 516| 516| 			translate("You have been disconnected.") :
| 517|    |-		!assignedState ?
|    | 517|+					!assignedState ?
| 518| 518| 			translate("You have left the game.") :
| 519| 519| 		assignedState.state == "won" ?
| 520| 520| 			translate("You have won the battle!") :
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 3.
|----|    | /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/summary/summary.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/phabricator_lint/binaries/data/mods/public/gui/summary/summary.js
| 515| 515| 		g_GameData.gui.disconnected ?
| 516| 516| 			translate("You have been disconnected.") :
| 517| 517| 		!assignedState ?
| 518|