Write setting with its value in the user config file.

missing space before *

also space

Maybe name writeSettingToUserConfig

nice finds

@leper do you know why we call both functions, isn't the second one implying the first? (with seeing the SetStringValue call in ConfigDB L451)
Also for all cases below

unneeded braces

inlinable

looks like redundant with the proposed name

same

redundant

inlinable, while on it nuke the foo.toString to String(foo)

(thought the same want to ask later :( ) also ther is Engine.ConfigDB_WriteFile function

Yes. No.

Why do we call both functions?, what part of the first is not implied in the second?

Im thinking it sets internal var and writes it into file

ah got it, my first test (chat extension) case simply failed (due to chat window is inside the session and stores the value there), however instincts on IRC were right:
(22:15:27) bb: the first sets it temporarily, the second for permanent in the file
(22:26:09) bb: WriteValueToFile writes to file (and not to memory), CreateValue writes to memory (and not file)
confirmed with using the STUN option in gamesetup_mp

maybe nuke the whole function

Put into confirmSetup() where it is called?

slightly worried about the name now, seeing the above observation, don't only write it to the file but also change it for the current instance. Maybe we need to go for saveSettingAndWriteToUserConfig (sorry for not mentioning earlier)

Same goes for the comment ofc

As long as we only use one function in general that is often used for setting a user config setting, why not giving that an easy general name f.e. writeToUserConfig or writeToConfig(name, value) use this generaly and explain in js doc that it is updating config in cache and write it into file?

Same would be for D1216 an easy general name readConfigSetting or readFromConfig or getConfig(name).

Not seeing why we need big name for an easy function.

Shall make things easier not more complicating in big names.

it seems, that a simple

Engine.ConfigDB_CreateValue("user", setting, value);
Engine.ConfigDB_WriteFile("user", "config/user.cfg");

is sufficient instead of

Engine.ConfigDB_CreateValue("user", setting, value);
Engine.ConfigDB_WriteValueToFile("user", setting, value, "config/user.cfg");

correct @leper ?

No.

Why its working for me

using it here D210 lobby.js L717. seems work

Both functions have a different purpose:
Engine.ConfigDB_WriteValueToFile adds the given value to the file
Engine.ConfigDB_WriteFile writes all current values in memory to the file. That's something we usually don't want to do (people may have set some options only for the current session and do not want to have them saved in their config file behind their back). So it is also certainly wrong to use it in D210 (although i've not looked at the code). Engine.ConfigDB_WriteFile should in principle only be used when clicking the save button while you are in the option panel.

Tx!:)