Page MenuHomeWildfire Games
Differential D1220

Disable attack as formation
ClosedPublic
Actions

Authored by temple on Jan 12 2018, 7:14 PM.

Details

Reviewers
wraitii
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP21042: Disable attack as formation
Summary

Units in formations that can attack as formation behave weirdly, reforming at random times. It seems better to remove this feature for the moment.
(There are other formation fixes that haven't been committed yet, they may be contributing to the bad behavior.)
(Units in formation can still behave weirdly with attack-move, but it's not as bad.)

Test Plan

Agree.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

temple created this revision.Jan 12 2018, 7:14 PM
temple added a reviewer: Restricted Owners Package.Jan 16 2018, 8:42 PM
temple added a comment.Jan 16 2018, 9:55 PM

Another reason is #4951, a bug where you can capture buildings and siege without getting close to them. (I haven't explored why that happens.)

wraitii accepted this revision.Jan 21 2018, 3:51 PM
wraitii added a subscriber: wraitii.

Attacking as a formation definitely needs to be rewritten.

This revision is now accepted and ready to land.Jan 21 2018, 3:51 PM
Closed by commit rP21042: Disable attack as formation (authored by temple). · Explain WhyJan 28 2018, 2:32 AM
This revision was automatically updated to reflect the committed changes.
wraitii mentioned this in rP22081: Rome Testudo & Anti-Cavalry formations animations:.Jun 24 2019, 1:14 PM

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
templates/
special/
formations/
2 lines
2 lines
2 lines
2 lines
2 lines

Diff 5530

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/phalanx.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/skirmish.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/syntagma.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/testudo.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/wedge.xml

Loading...
Wildfire Games · Phabricator