Contrary to what was said in the comment in the code, units were not ejected when upgrading towards a non garrisonHolder
Details
Details
- Reviewers
- None
- Commits
- rP20939: Garrisoned units are lost after an upgrade towards a non garrison holder
Put some units on a wall and upgrade it to a gate
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
That bug was already there before rP20393 (see line 221 before patch). And anyway, i don't understand what you mean with this quote? more context is usually a good idea.
Comment Actions
Added the backref, to the concern raised there, since this is the bug I mentioned in that revision (so when we commit this the concern should be closed). IIRC back then I checked that the revision was causing the bug, but I might be mistaken in that.
Comment Actions
ok thanks, i was not sure there was not something else. Then that patch should fix your concern. Care to review it :)