Differential D1232
Scrollbug when player/gamelist receives update in lobby Authored by ffffffff on Jan 18 2018, 5:25 PM. Tags None Subscribers None
Details The code introduces selected_unscrolled attribute to CList.cpp. So we can keep selected player on updated playerlist selected, if position in list changed, but doesn't go for an update to auto scroll to it, so we can keep our scroll view consistent too. Same for updated gamelist. Keep selected game consistent, if position changed, but dont loose scroll view. select a player. scroll player out of view in list. Make updateplayerlist call by type /away in chat. select a game. scroll out of view. try to get updategamelist call.
Diff Detail
Event TimelineComment Actions Better version with unscrolled code as normal behaviour should be autoscroll feature when selected setted. So make new attribute which sets selected item but dont update auto scroll. Comment Actions Not to be implemented like this. There may only be one property specifying the selection. Comment Actions
Im Sinne von günstig oder billig? :P That property would have the disadvantage of two variables storing the same data (selected ID). I would accept an autofocus JS-only boolean that is instantly set to false when receiving the changed message however. https://trac.wildfiregames.com/ticket/4987#comment:6 JS-only means the new property is not going to be added to gui.rng nor gui.rnc. Also move the debug code out of the patch. Comment Actions Works. Really neat patch, seems even nicer than a C++ method after all. Thanks a lot for helping out on this one!
| |||||||||||||||||||