Show civ in player teamdescription in lobby
ClosedPublic
Actions

Authored by ffffffff on Jan 18 2018, 11:49 PM.

Details

Reviewers

elexis
bb

Commits

rP20967: Add civ settings in lobby for the selected game

Summary

Its already prepared in gamedescriptions code but not send civ data.

Maybe its nice to show.

This patch adds , \"Civ\": "iber" (4 char civ code) to stringified playerListUpdate sent to lobby. Very small extra data for nice info.

Test Plan

test

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ffffffff created this revision.Jan 18 2018, 11:49 PM

ffffffff edited the summary of this revision. (Show Details)Jan 19 2018, 12:05 AM

Indeed very nice little feature, adding the missing jsdoc when comitting

binaries/data/mods/public/gui/lobby/lobby.js
11 ↗	(On Diff #5373)	/** * Used for civ settings display of selected game. */
binaries/data/mods/public/gui/session/session.js
1415 ↗	(On Diff #5373)	correct since every human or ai player has a civ

This revision is now accepted and ready to land.Jan 22 2018, 9:10 PM

Closed by commit rP20967: Add civ settings in lobby for the selected game (authored by bb). · Explain WhyJan 22 2018, 9:38 PM

This revision was automatically updated to reflect the committed changes.

Owners added a subscriber: Restricted Owners Package.Jan 22 2018, 9:38 PM

@Imarok did we leave this one out intentionally in rP18534 or was it a mistake in that commit? I recall scythetwirler stating something about performance, but that was only not showing team-changes in the gamesetup, right?

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

lobby/

lobby.js

5 lines

session/

session.js

2 lines

Diff 5433

View Options

ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js