Differential D1238

Bugfix Top Panel
ClosedPublic
Actions

Authored by OptimusShepard on Jan 20 2018, 2:56 PM.

Details

Reviewers

Imarok

Commits

rP21015: Fix the positions of the top panel bottom

Summary

bugfix the distances between the buttons in the right corner

Test Plan

look at the right top corner

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

OptimusShepard created this revision.Jan 20 2018, 2:56 PM

Harbormaster failed remote builds in B4574: Diff 5388!Jan 20 2018, 2:56 PM

I thought the positions are already computed - they ought to be.

In D1238#50151, @elexis wrote:

I thought the positions are already computed - they ought to be.

Only a few of them, or did I overlook this? I seen it because I'm still writing a patch for better ultrawide screen support in game

In D1238#50151, @elexis wrote:

I thought the positions are already computed - they ought to be.

Nope they aren't.
And I think only four static buttons don't justify computing them.

This revision is now accepted and ready to land.Jan 25 2018, 7:03 PM

Closed by commit rP21015: Fix the positions of the top panel bottom (authored by Imarok). · Explain WhyJan 25 2018, 10:34 PM

This revision was automatically updated to reflect the committed changes.

Owners added a subscriber: Restricted Owners Package.Jan 25 2018, 10:34 PM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

session/

top_panel/

button_game_speed.xml

2 lines

button_trade.xml

2 lines

Diff 5495

View Options

ps/trunk/binaries/data/mods/public/gui/session/top_panel/button_game_speed.xml