Page MenuHomeWildfire Games

Default Hide Tab Content Of Game Settings In Game Setup
ClosedPublic

Authored by ffffffff on Jan 22 2018, 7:28 AM.

Details

Summary

Cleaner appearance when entering gamesetup.xml gui.

compared to previous

Test Plan

test

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ffffffff created this revision.Jan 22 2018, 7:28 AM
bb added a comment.Jan 22 2018, 2:34 PM
  1. wrong way to go about this, the default should be set in the file head (there is a comment for it even)
  2. disagree, since we should avoid unnecessary clickwork by the player, so I rather have the first tab open already (convince someone else if you have strong opinion)
Imarok resigned from this revision.Jan 22 2018, 3:13 PM

No opinion

ffffffff edited the summary of this revision. (Show Details)Jan 22 2018, 4:45 PM
ffffffff added subscribers: mapkoc, Grugnas, Dunedan.
ffffffff added a subscriber: gentz.
ffffffff abandoned this revision.Jan 23 2018, 9:39 PM

Now feeling fine with new options ui opened.

I really love the new tab design @bb . but thinking again that we need to hide the options first as before as it's much cleaner

number of players and map can be seen anyway

the rest can be still easily seen by opening according tab (scrolling, clicking, hitting tab)

and view easily restored with D1242 esc key

less crowded then

ffffffff reclaimed this revision.Feb 7 2018, 3:39 PM
bb added inline comments.Apr 16 2018, 1:29 PM
binaries/data/mods/public/gui/gamesetup/gamesetup.js
1224 ↗(On Diff #5417)

Probably cleaner would be to add a default argument to placeTabButtons

Should this be open for SP players / hosts and hidden for clients?

ffffffff updated this revision to Diff 6436.Apr 20 2018, 3:19 PM

if not controller hide tabs default

bb accepted this revision.Apr 23 2018, 4:38 PM

default argument also brings some duplicate hardcodings (for the controller case), so thx for the stubbornness

When joining a game now you can see the slide, which looks ugly, so we need to set the size directly in the changed lines too => requires moving around some functions, so doing that beforehand. We could then trivially add 1 function call in this patch to nuke the sliding so accepting

This revision is now accepted and ready to land.Apr 23 2018, 4:38 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Apr 23 2018, 5:29 PM