Page MenuHomeWildfire Games

Make Help Command Available In Gamesetup And In-Game Chat
Needs ReviewPublic

Authored by ffffffff on Jan 22 2018, 7:52 PM.

Details

Reviewers
elexis
bb
Imarok
Summary

Show usage of available commands in help command.

Tooltips Screenshots: https://imgur.com/a/58z70

In Gamesetup:

In Game:

Would be nice to have additional D908.

Also D928.

Test Plan

test

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Jan 22 2018, 7:52 PM
ffffffff edited the summary of this revision. (Show Details)Jan 22 2018, 7:55 PM
ffffffff edited the summary of this revision. (Show Details)Jan 22 2018, 8:06 PM
ffffffff edited the summary of this revision. (Show Details)Jan 27 2018, 11:14 PM
bb added a comment.Jan 27 2018, 11:54 PM

The lobby help has a slighlty different layout, keep it in sync if possible

binaries/data/mods/public/gui/common/network.js
41

Don't know how translators will react on commands in their string, since they shouldn't be translated, maybe a sprintf?

69

Chat help command format

71

sad we don't have coloredtext nuked yet into guitags

binaries/data/mods/public/gui/session/session.js
374–375

newline style in code different from gamesetup, change this one imo

bb added a comment.Jan 30 2018, 12:43 PM

in the lobby there is a / before the commands in the help, ingame/gamesetup not, pls keep that in sync
Ingame there are a lot more commands: /me, /team, /allies etc. they should show up in the help too. Maybe one should make 1 big object with all commands splitted out in the different variables we have now, so

var g_ChatCommands = {
  "network":  {
      "/ban": foo,
      "/kick": foo2,
      etc.
  },
  "addresses": {
      "/team": foo3,
      "/allies": foo4,
     etc.
  },
  etc.
}

(maybe the network things should be left out/added with code, since they are defined in another file)

binaries/data/mods/public/gui/common/color.js
175

color.js looks like a bad place for tooltip getters, but as autocomplete tooltip does the same, meh, maybe another patch could relocate them

binaries/data/mods/public/gui/common/network.js
42

trialling comma

72

using sprintf here is ok with me, as potentially more commands could use it

binaries/data/mods/public/gui/lobby/lobby.js
352

:)