Page MenuHomeWildfire Games

Hotkey cleanup in-game and hotkey tooltips
Needs ReviewPublic

Authored by ffffffff on Jan 23 2018, 1:02 PM.

Details

Reviewers
elexis
bb
Imarok
Summary

All Screenshots From The Current Menu Tooltips: https://imgur.com/a/X37lk

Test Plan

Move cursor over menu buttons named in code. (all)

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ffffffff created this revision.Jan 23 2018, 1:02 PM
ffffffff retitled this revision from Wip Ingame Tooltips to Wip Ingame Menu Tooltips.
ffffffff added inline comments.Jan 23 2018, 1:06 PM
binaries/data/mods/public/gui/session/menu.js
77

Maybe name updateMenuButtons.

81

Is this actually what we want compared to colorizeHotkey() in color,js?

Dont like this "Unassigned hotkey: %(hotkeyName)s" String from it.

ffffffff retitled this revision from Wip Ingame Menu Tooltips to Wip Ingame Menu Buttons Tooltips.Jan 23 2018, 5:43 PM
ffffffff edited the summary of this revision. (Show Details)Jan 23 2018, 5:49 PM
ffffffff edited the test plan for this revision. (Show Details)
ffffffff updated this revision to Diff 5463.Jan 23 2018, 9:34 PM
ffffffff edited the summary of this revision. (Show Details)

all tooltips

ffffffff edited the summary of this revision. (Show Details)Jan 23 2018, 9:37 PM
ffffffff edited the test plan for this revision. (Show Details)
ffffffff added inline comments.Jan 23 2018, 9:42 PM
binaries/data/mods/public/gui/session/menu.js
69

jsdocs missing
/**

  • Setting menu buttons tooltips and hotkey descriptions plus enable or disable them. */

btw is a campaign with such a map from screenshots upcoming with ultra high mountains? actualy thats a terrain manager bug. But looks awesome nice.

ffffffff retitled this revision from Wip Ingame Menu Buttons Tooltips to Ingame Menu Buttons Tooltips.Jan 25 2018, 11:21 PM
elexis requested changes to this revision.Jan 25 2018, 11:57 PM
elexis added inline comments.
binaries/data/mods/public/gui/session/menu.js
74

hotkey property is redundant and should be received by Engine.GetGUIObjectByName("name").hotkey

This revision now requires changes to proceed.Jan 25 2018, 11:57 PM
Imarok added inline comments.Jan 25 2018, 11:58 PM
binaries/data/mods/public/gui/session/menu.js
70

Maybe "Toggle the in-game menu"?

74

not just "enabled": Engine.HasXmppClient ?

ffffffff planned changes to this revision.Jan 29 2018, 8:42 AM
This comment was removed by ffffffff.
binaries/data/mods/public/gui/session/menu.js
70

claro!

74

nice!!

ffffffff updated this revision to Diff 5730.Feb 8 2018, 11:23 PM
ffffffff updated this revision to Diff 5736.Feb 9 2018, 12:32 AM
ffffffff updated this revision to Diff 5769.Feb 11 2018, 6:29 PM
ffffffff retitled this revision from Ingame Menu Buttons Tooltips to Hotkey cleanup in-game and hotkey tooltips.
ffffffff added inline comments.Feb 11 2018, 6:32 PM
binaries/data/mods/public/gui/session/session.js
608

remove

ffffffff added inline comments.Feb 12 2018, 3:58 PM
binaries/data/mods/public/gui/session/input.js
194

...AndType()

971

// Look for function, that takes the hit and demands no more hotkey functions to execute.