Details
- Reviewers
elexis bb - Commits
- rP21005: Move minimap color deserialization fix out of the gui
(We'll use an UpdateDisplayedPlayerColors function in D754, but I guess it makes sense to remove it here first.)
Test that minimap colors are correctly set after e.g. loading a save game.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Good. Not the most hurtful thing to have the GUI Interface function as it's going to be reused in short time, but indeed makes sense to add a commit to inform the readers how it works ideally at this state.
Tested by first removing the session init call and noticing pink minimap colors and then applying the patch and seeing that the colors are initialized as expected.
The MT_Deserialized update can remain there, as the simulation should not rely on the JS code to be initialized correctly. The JS GUI ought to use simulation features only optionally.
Thanks for the follow-up.