Show Fight Activity Ratio Score in Summary
AbandonedPublic
Actions

Authored by ffffffff on Feb 4 2017, 8:26 AM.

Details

Reviewers

elexis

Summary

Show A Ratio between Economy and Military to get a link between them.

Test Plan

test Resolution 1024x768

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

ffffffff created this revision.Feb 4 2017, 8:26 AM

This comment was removed by ffffffff.

Correct indention

military_eco_ratio_score_summary.diff1 KBDownload

corrected writing "ratio" small r

The patch doesn't seem complete, please make the patch by "svn diff" from the root of the repo.

counters.js
130 ↗	(On Diff #447)	You can use `!scoScore` instead of `ecoScore == 0` , maybe meh
131 ↗	(On Diff #447)	Split the returns to the next line.

military_eco_ratio_score_summary.diff1 KBDownload

corrections bb

In D126#4223, @bb wrote:

The patch doesn't seem complete, please make the patch by "svn diff" from the root of the repo.

actualy i dont have the svn 0ad repo. doing jit in public.

updated from proposals.

Is this really needed?
Its kind oft redundant, as we already have military score and economic score. And I think the term Score is just wrong here: Usually a high score is something good and a low score is bad, where a high and a low mil/eco ratio cannot really be called good.
(NB: not decided features should first go to trac afaik)

In D126#4273, @Imarok wrote:

Is this really needed? Its kind oft redundant, as we already have military score and economic score.

Not entirely useless, as the ratio isn't obvious given the numerator and denominator. An estimation by the reader would have a too high error margin to be meaningful.
The message of the ratio is showing how much potential (economic score) the player has actually transfered and used. The argument is equal to the kill-death-ratio.
But I agree that it wouldn't hurt to wait for more opinions on this.

And I think the term Score is just wrong here: Usually a high score is something good and a low score is bad, where a high and a low mil/eco ratio cannot really be called good.

(NB: not decided features should first go to trac afaik)

Team score wrong indeed as posted by ffffffff / fpre in irc, so this couldn't be committed if agreed upon the feature.

This revision now requires changes to proceed.Feb 5 2017, 2:00 AM

Maybe the misc tab would be a better place for this ratio

In D126#4458, @Imarok wrote:

Maybe the misc tab would be a better place for this ratio

i agree. got another example

could be interesting in first tab cause its ratio from eco and military score.

This add can be useful for the one who wants to balance his play style, knowing if he is balancing too much on economy instead of combat. I'd say to add that to the Miscellaneus tab since it is not properly a score but a ratio, and it is coherent with other ratios displayed there

This comment has been deleted.

That information is imo meaningless.
I would suggest to close that.

ffffffff retitled this revision from Show Military Economy Ratio Score in Summary to Show Fight Activity Ratio Score in Summary.Apr 10 2017, 11:06 AM

working team total

Screenshot from actual work. Now implemented functionality.

Maybe named Fight Activity better. not sure.

The "Total" of a ratio is the weighted average. Not sure if that was taken into account and how to weight each player (for the total score is an arbitrary value).
Why do we show those "scores" in the first place? IMO we should only show numbers that are not made up like number/cost of units produced/buildings constructed, number/cost of units killed/buildings razed/captured. If a player want to make up things he can do it himself. And different styles of play will lead to different "scores" while they still can be as effective.

The patch is not too bad but also not too good. In particular not convincing enough for us to commit it I feel.

For example the screenshot with Grugnas and Dizaka. Similar military score, but one has a bigger economy. That will yield a smaller ratio. The reader however compares the numbers amongst players and expects the one with the bigger number to more militarily active.
And another player might have one unit gathering resources and killed 2 enemy women and got really good ratio.
The existing numbers in the summary screen are lying too, but it's probably better to have players judge the player activity from both numbers instead of the ratio.

Revive some sort of this patch? Rather liking it again. Maybe Eco/Military Ratio named? Im feeling Fight Activity name from last screenshot is not bad.

ffffffff added subscribers: mapkoc, Hannibal_Barca, gentz.Jan 24 2018, 6:24 AM