Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (309 tests).....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (309 tests).....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

We have an internationalization ticket on trac that is also about plural strings for simulation-sent GUI chat notifications.
This ticket was never resolved because I believe in order to do it properly, one would have to not pick a string in the simulation and send that but send the entire object and let the GUI pick the string.
If we use markPlural in the sim we ought to use translatePlural in the GUI.
If it happens to work that we can call translate() on one of the strings that were marked by markForPluralTranslation, then that sounds rather coincidental.
Looking at the C++ code, translatePlural ends up using the internationalization library we have dictionary->translate_plural(singularSourceString, pluralSourceString, number);.

I assume one should be able to test the patch by running an AI 4v4 100pop match with very few res, change the gamespeed to 20x and change perspective to one player or be one player.

Side node, aichat should become translated-chat or simulation-chat as it is also used by non-AI simulation components.

The cleaner approach to fix this thing and the mentioned ticket would be to implement translated-chat-plural.

I found the #4597 ticket by chance in one of the Transifex reports, it was not my intention to fix it, I just thought I had fixed it with these changes.

Should I fix the inline comment and propose this change as a fix that solves the issues reported by translators but does not fix the ticket?

Does passing markForPluralTranslation actually work? If not, then not.
I suspect we just want to add few GUI code and fix it well.

I am having trouble verifying that it works, as I am not familiar with Petra. Originally, I tried to ask for an alliance to all 7 players in a game, hoping that at least one would ask for tributes, but n luck. Now I have edited handleDiplomacyRequest(), commenting out part of its content to force the last case of the if/else statement to occur, but I still could not get an AI player to request tributes. I will have to look deeper into the Petra AI code to try and get the AI to send one of those plural messages.

@mimo got a hack to trigger the chat messages?

See D1382 for a way to display all AI messages.