I am not sure when it happened (did not bisect), but the CStr.h inclusion disappeared in JSInterface_Mod.h. This didn't break PCH builds because this header is precompiled in the engine project.
Details
- Reviewers
Imarok - Commits
- rP21075: Fix non-PCH build by adding an explicit include.
Build with update-workspaces.sh --without-pch.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (309 tests).....................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (309 tests).....................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
Could reproduce the issue and confirm the fix. Looks reasonable.
According to the files' changelog, this seems to be the case since ever.
the CStr.h inclusion disappeared in JSInterface_Mod.h
Are you sure the CStr include was present in the headers at any time? Since there is a CStr but no CStr include in the header of this file when it was introduced in rP15677.
Thanks for testing! I will commit tomorrow.
Yes sorry I was unclear: I'm not saying the include used to be in that file, but it was included somewhere in the chain of includes starting from scriptinterface/ScriptInterface.h until recently. Indeed, I successfully built without PCH when I fixed the premake5 scripts a big couple of weeks ago.