Page MenuHomeWildfire Games

Drop premake4 support [after A23]
ClosedPublic

Authored by Itms on Jan 30 2018, 8:49 AM.

Details

Summary

Premake 4 is not used anymore, so we should drop support and rejoice ? I propose we do this after the release. That way, if something unexpected happens to the packagers, they can still build the game with --premake4 and release A23 without a headache.

Note: I didn't include the removal of build/premake/premake4 because that clutters the diff. This will be done upon committing. You can remove it manually for testing, but since the lua files for p4 are deleted, if this diff breaks something, it will break even without deleting the folder.

Test Plan

Check that building still works.
Don't forget to delete build/premake/premake4 for testing.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Itms planned changes to this revision.Jan 30 2018, 8:49 AM
Itms created this revision.

After the release.

Vulcan added a subscriber: Vulcan.Jan 30 2018, 9:19 AM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (309 tests).....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (309 tests).....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
Executing section Default...
Executing section Source...
Executing section JS...
Itms updated this revision to Diff 7068.Dec 26 2018, 12:45 PM
Itms edited the test plan for this revision. (Show Details)

Rebased this patch before committing it.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/833/

This revision was not accepted when it landed; it landed in state Needs Review.Dec 26 2018, 5:01 PM
This revision was automatically updated to reflect the committed changes.