Page MenuHomeWildfire Games

New Map - Dodecanese
ClosedPublic

Authored by Hannibal_Barca on Feb 3 2018, 3:42 PM.

Details

Summary

New naval map featuring many small islands in the Aegean Sea.

Maybe @elexis wants to add something special (volcano?)

Test Plan

Test the map.
Test in nomad mode and try to guarantee a reasonably big island for the start.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Hannibal_Barca created this revision.Feb 3 2018, 3:42 PM
Vulcan added a subscriber: Vulcan.Feb 3 2018, 4:21 PM

Successful build - Chance fights ever on the side of the prudent.

Updating workspaces...
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (309 tests).....................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (309 tests).....................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...
elexis added a comment.Feb 4 2018, 2:32 AM
  • volcanoes
  • bridge actors
  • chain placed player islands
  • less regular island distances
  • no space to build ccs?
  • broken hut actors
  • add 3rd dimension? bluff-like elevation?
  • underwater bumps like corsica, aegean
  • whale, shark
  • (sea-gulls in case we had models?)
  • possibly more mines
  • U-shaped islands
  • some shorelines should be longer than 1-2 tiles
  • few cliff areas at the shore were good
  • should look through atlas list for random actors (shipwreck at most 1 per map)
binaries/data/mods/public/maps/random/islets.js
2 ↗(On Diff #5640)

rmgen2 not used afaics

78 ↗(On Diff #5640)

TODO: remove dupe

164 ↗(On Diff #5640)

-1 tab in this line and following

binaries/data/mods/public/maps/random/islets.json
6 ↗(On Diff #5640)

also "new"

In D1277#52141, @elexis wrote:
  • volcanoes ---------------[ 1-2 max ]
  • bridge actors --------------[ bit weird for ships, units can't cross either ]
  • chain placed player islands ---------------[ good ]
  • less regular island distances -------------[ good ]
  • no space to build ccs? -------------[ it's fine, there will be the same number of large islands as the players anyway, their job is to locate them and clear the forests to build (or if lucky build on a smaller cc)]
  • broken hut actors ------------[ ok ]
  • add 3rd dimension? bluff-like elevation? ----------[ ok ]
  • underwater bumps like corsica, aegean----------------------[sure]
  • whale, shark----------------------[sure]
  • (sea-gulls in case we had models?)----------------------[sure]
  • possibly more mines ----------[ needed ]
  • U-shaped islands ----------------[ good to have]
  • some shorelines should be longer than 1-2 tiles----------------------[sure]
  • few cliff areas at the shore were good----------------------[sure]
  • should look through atlas list for random actors (shipwreck at most 1 per map)----------------------[sure]
elexis retitled this revision from New Map - Islets to New Map - Dodecanesian Islets.Feb 18 2018, 2:52 AM
elexis retitled this revision from New Map - Dodecanesian Islets to New Map - Dodecanese.Feb 18 2018, 2:57 AM
elexis requested changes to this revision.Feb 18 2018, 3:08 AM
  • volcanoes done
  • bridges done
  • broken huts not good since it's greece now
  • U shaped islands rarely possible

Requesting changes just to express the annoyance.

binaries/data/mods/public/maps/random/islets.js
63 ↗(On Diff #5640)

clWater is never written to, but read from!
It shouldn't exist because it's the opposite from clIsland

73 ↗(On Diff #5640)

clCityPatch never actually written to, can be omitted

78 ↗(On Diff #5640)

(done)

125 ↗(On Diff #5640)

new LayeredPainter([tPrimary , tPrimary, tPrimary], [1, 6]),
is the same as
new LayeredPainter([tPrimary] []),
is the same as
new TerrainPainter(tPrimary),.

140 ↗(On Diff #5640)

this is passing tCity, clCityPatch as innerTerrain

168 ↗(On Diff #5640)

This shoreline painting does something almost identical with the shoreline painting below (paintBasedOnHeight), must be nuked. Also this island texturing is different from the one above.

172 ↗(On Diff #5640)

clForest useless as none have been set yet
clCitypatch useless since it is included in clIsland

173 ↗(On Diff #5640)

no, you dont want the number of islands to depend on the number of players, otherwise get empty sea with 2 players

224 ↗(On Diff #5640)

Hannibal told me it's intended that metal mines can't be placed on player islands.

255 ↗(On Diff #5640)

(You did indent that intentionally like that, but it should be the same as everywhere else.)

298 ↗(On Diff #5640)

clFood missing, otherwise placing trees into deer.
But if you add it, there will be less forests. What the other maps do is place forests first so that the larger areas are covered first and the smaller entities fit in between.

349 ↗(On Diff #5640)

4 different createForest calls? merging into one.

374 ↗(On Diff #5640)

water shouldn't have to be painted more than once

375 ↗(On Diff #5640)

The order of random map duties is as follows:

  • change heights
  • paint terrain
  • place players
  • place forests
  • place mines and animals
  • place decoratives

(this way there are no corrections needed and no useless terrain painting calls)

binaries/data/mods/public/maps/random/islets.json
5 ↗(On Diff #5640)

I got a better name and a description by Hannibal Barca today

This revision now requires changes to proceed.Feb 18 2018, 3:08 AM
elexis accepted this revision.Feb 18 2018, 3:10 AM

Fixed all of that, thanks for the map, it's good!

This revision is now accepted and ready to land.Feb 18 2018, 3:10 AM
This revision was automatically updated to reflect the committed changes.
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Feb 18 2018, 3:38 AM
elexis added inline comments.Feb 20 2018, 12:11 AM
binaries/data/mods/public/maps/random/islets.js
231 ↗(On Diff #5640)

oStoneLarge and oStoneSmall = metal mines? That explains why there are so few of them...