Clean up the updateBandbox function
ClosedPublic
Actions

Authored by OptimusShepard on Feb 11 2018, 2:15 PM.

Details

Reviewers

elexis
bb

Commits

rP21185: Cleanup updateBandbox function with using vector functions

Summary

add some vector functions
see D1288

Test Plan

test the bandBox

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

OptimusShepard created this revision.Feb 11 2018, 2:15 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/5/display/redirect

Harbormaster completed remote builds in B4917: Diff 5762.Feb 11 2018, 2:17 PM

update the comments

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/6/display/redirect

Harbormaster completed remote builds in B4918: Diff 5763.Feb 11 2018, 2:26 PM

Code should do the same, testing says it is ok

binaries/data/mods/public/gui/session/input.js
353 ↗	(On Diff #5763)	"Returns the coordinates of the vertices." or even better "@returns {array} The coordinates of the vertices."

This revision is now accepted and ready to land.Feb 12 2018, 12:21 PM

Closed by commit rP21185: Cleanup updateBandbox function with using vector functions (authored by bb). · Explain WhyFeb 12 2018, 12:41 PM

This revision was automatically updated to reflect the committed changes.

Owners added a subscriber: Restricted Owners Package.Feb 12 2018, 12:41 PM

Thanks for the patch and review Optimus and bb!

thx for reviewing

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

session/

input.js

30 lines

Diff 5773

View Options

ps/trunk/binaries/data/mods/public/gui/session/input.js

Clean up the updateBandbox functionClosedPublicActions