Differential D1297

Another bunch of summary reconfigurations by game effect
Needs ReviewPublic
Actions

Authored by ffffffff on Feb 12 2018, 5:53 PM.

Details

Reviewers: None

Summary

https://imgur.com/a/U6JTt

Test Plan

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

ffffffff created this revision.Feb 12 2018, 5:53 PM

What's the logic? More important things first?

In the market tab, there should be a common header for food/wood/stone/metal exchanged and an explanation of what the green and red numbers are, like in the resources tab with "Resource Statistics (Gathered / Used)".

binaries/data/mods/public/gui/summary/layout.js
25–27	Civic center before military and fortress? It seems the most important thing.
31	Seems weird to include outposts at all.
103–108	I would keep this here next to the total numbers. Maybe it would be nice in this whole tab to have gather/used (and sent/received) be on separate lines, then the columns wouldn't have to be so wide and it could better fit 1024 x 768. (I guess in market tab too.) (Or do we just make the columns narrower and it makes two lines automatically? I didn't check the code.)
171–172	I would keep barter efficiency next to the exchange numbers.
188	I would keep map exploration next to the other map numbers.

What's the logic? More important things first?

yes indeed need to over look it again but its the direction

In the market tab, there should be a common header for food/wood/stone/metal exchanged and an explanation of what the green and red numbers are, like in the resources tab with "Resource Statistics (Gathered / Used)".

great ideas will look tomorrow again

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

gui/

summary/

layout.js

60 lines

Diff 5774

View Options

binaries/data/mods/public/gui/summary/layout.js

Another bunch of summary reconfigurations by game effectNeeds ReviewPublicActions